Skip to content

Conversation

@ricardoroquepa
Copy link

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Nov 27, 2024
@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/grbl/grbl

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @ricardoroquepa
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/grbl/grbl

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @ricardoroquepa
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 self-assigned this Nov 28, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ricardoroquepa. Thanks for your interest in contributing to the Arduino Library Manager index.

As the bot explained, this library does not meet the requirements for addition to Library Manager:

https://github.com/arduino/library-registry/blob/main/FAQ.md#what-are-the-requirements-for-a-library-to-be-added-to-library-manager

You will need to work with the maintainers of Grbl to bring it into compliance. I guess you didn't see this statement in the readme of the repository you are attempting to submit:

Grbl v1.1 has been released here!
Notice: This site will be phased out and moved to the new one!

So you should make sure to focus your attention on the current Grbl repository instead of the one that was phased out eight years ago!

Since the Grbl project is not actively maintained, bringing it into compliance might take quite some time. For example, here is a request from five years ago, which has been ignored (though to be fair the initial request was nonsensical so the maintainers might not have been able to understand it):

gnea/grbl#590

For that reason, I'm going to close this pull request. But you are very welcome to submit a new pull request once the Grbl library meets all the requirements.

I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.


Sometimes we learn that the motivation behind people submitting older libraries to the Library Manager registry is simply because they want to use the library but can't figure out how to install it. Valid library submissions are welcome regardless of the motivation, so that is fine (and it would be great to have Grbl in Library Manager), but not an efficient way to progress with a project. So if you want to learn how to install Grbl right now, then just follow the instructions here:

https://github.com/gnea/grbl/wiki/Compiling-Grbl

If you have any problems or questions, post over on Arduino Forum and we'll help you out:

https://forum.arduino.cc/c/software/ide-2-x/93

@per1234 per1234 closed this Nov 28, 2024
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conclusion: invalid Issue/PR not valid topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants