Skip to content

Conversation

@SooDragon
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

Hi @SooDragon.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Dec 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

Arduino Lint has suggestions for possible improvements to https://github.com/Geekble-Maker/Geekble_Note2Freq:

Linting library in Geekble_Note2Freq
WARNING: library.properties name value Geekble_Note2Freq is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format 
         (Rule LP010)                                                                                           
WARNING: A commonly misspelled word was found in the library.properties sentence field. Suggested correction: Library   
         for easy conversion of musical note to frequency.                                                              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP033)                                                                                                   
WARNING: A commonly misspelled word was found in the library.properties paragraph field. Suggested correction: Library  
         for easy conversion of musical note to frequency.                                                              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP035)                                                                                                   
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in Geekble_Note2Freq/examples/Mary_had_a_little_lamb

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 5 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

ERROR: Arduino Lint found errors with https://github.com/Geekble-Maker/Geekble_MotorOrgel:

Linting library in Geekble_MotorOrgel
WARNING: library.properties name value Geekble_MotorOrgel is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format  
         (Rule LP010)                                                                                            
ERROR: Library name Geekble_MotorOrgel not found in the Library Manager index. Library names are not allowed to change  
       after being added to the index.                                                                                  
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: Unable to load the library.properties url field: 404 Not Found                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP042)                                                                                          
WARNING: library.properties includes field item(s) Geekble_Note2Freq.h not found in library.                   
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 1 ERRORS, 5 WARNINGS

-------------------

Linting sketch in Geekble_MotorOrgel/examples/A4988_Mary_had_a_little_lamb

Linter results for project: no errors or warnings

-------------------

Linting sketch in Geekble_MotorOrgel/examples/ULN2003_Mary_had_a_little_lamb

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @SooDragon
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 December 8, 2024 06:37
@per1234 per1234 mentioned this pull request Dec 8, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @SooDragon. It looks like you are attempting to do two things with this pull request:

A. Add https://github.com/Geekble-Maker/Geekble_MotorOrgel
B. Change URL of https://github.com/geekblemaker/Geekble_note2freq to https://github.com/Geekble-Maker/Geekble_Note2Freq

Please use a separate pull request for each distinct type of operation. The automated system is not capable of processing pull requests that contain both a submission and a URL change. So please submit a dedicated pull request if you want to submit https://github.com/Geekble-Maker/Geekble_MotorOrgel.

@per1234 per1234 added the status: changes requested Changes to PR are required before merge label Dec 8, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as duplicate of #5546

@per1234 per1234 closed this Dec 8, 2024
@per1234 per1234 added topic: URL change Change library repository URL conclusion: duplicate Has already been submitted and removed status: changes requested Changes to PR are required before merge topic: modification Change existing list entry labels Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conclusion: duplicate Has already been submitted topic: URL change Change library repository URL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants