Skip to content

Conversation

@benax-rw
Copy link

@benax-rw benax-rw commented Dec 8, 2024

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

A problem was found with your submission https://github.com/benax-rw/LiquidCrystal_I2C_SW

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @benax-rw
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@benax-rw
Copy link
Author

benax-rw commented Dec 8, 2024

I have added the required tag 1.0.0. Please re-review my library.

1 similar comment
@benax-rw
Copy link
Author

benax-rw commented Dec 8, 2024

I have added the required tag 1.0.0. Please re-review my library.

@benax-rw benax-rw closed this Dec 8, 2024
@benax-rw benax-rw reopened this Dec 8, 2024
@benax-rw
Copy link
Author

benax-rw commented Dec 8, 2024

I have added the required tag 1.0.0. Please re-review my library.

@per1234
Copy link
Contributor

per1234 commented Dec 8, 2024

@ArduinoBot please check it again.

@benax-rw note the second half of the instructions from the bot:

, mentioning @ArduinoBot in the comment.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

A problem was found with your submission https://github.com/benax-rw/LiquidCrystal_I2C_SW

ERROR: Invalid library.properties file: Error reading file: Error parsing data at line 0: Invalid line format, should be 'key=value'

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @benax-rw.
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@arduino arduino deleted a comment from github-actions bot Dec 8, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @benax-rw. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/benax-rw/LiquidCrystal_I2C_SW/blob/1.0.0/library.properties

(note that the file still incorrectly had a JSON data format at that point in the revision history)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Dec 8, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of a tidy repository, I'm going to close this due to lack of activity.

@benax-rw if you ever manage to make a new tag or release in your repository, please submit another pull request to add the library.

I'll continue to monitor this thread, so feel free to let me know if you have any questions or concerns.

@per1234 per1234 closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting for information More information must be provided before work can proceed topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants