-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Added PDLS #5751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PDLS #5751
Conversation
|
A problem was found with your submission https://github.com/PervasiveDisplays/Pervasive_Wide_Medium ❌ ERROR: The repository has no tags. You need to create a release or tag that matches the |
|
A problem was found with your submission https://github.com/rei-vilo/PDLS_Basic ❌ ERROR: The repository has no tags. You need to create a release or tag that matches the |
|
A problem was found with your submission https://github.com/rei-vilo/PDLS_Common ❌ ERROR: The repository has no tags. You need to create a release or tag that matches the |
|
Thanks for your interest in contributing to the Arduino Library Manager index @rei-vilo After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
@ArduinoBot please check it again. |
|
Hello! I'm checking your submission again. |
|
❌ ERROR: Arduino Lint found errors with https://github.com/rei-vilo/PDLS_Basic: |
|
❌ ERROR: Arduino Lint found errors with https://github.com/rei-vilo/PDLS_Common: |
|
Arduino Lint has suggestions for possible improvements to https://github.com/PervasiveDisplays/Pervasive_Wide_Medium: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @rei-vilo After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
per1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rei-vilo. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.
If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:
https://github.com/rei-vilo/PDLS_Basic/blob/9.0.2/library.properties
name=PDLS_Basic
version=9.0.2
author=Rei Vilo for Pervasive Displays
sentence=Library for Pervasive Displays iTC screens, extension boards and development kits
paragraph=Graphics and text primitives, normal and fast update
category=Display
url=https://pdls.pervasivedisplays.com/userguide/
architectures=*
depends=PDLS_Common
(note that no maintainer property is present at the tagged point in the repository's revision history)
https://github.com/rei-vilo/PDLS_Common/blob/9.0.2/library.properties
name=PDLS_Common
version=9.0.2
author=Rei Vilo for Pervasive Displays
sentence=Shared libraries including constants and utilities
paragraph=Required by Driver_EPD and PDLS libraries
category=Display
url=https://pdls.pervasivedisplays.com/userguide/
architectures=*
(note that no maintainer property is present at the tagged point in the repository's revision history)
❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.
Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
|
Thank you very much for the detailed instructions. Updated release 9.0.3 should do it. |
|
@ArduinoBot please check it again. |
|
Hello! I'm checking your submission again. |
|
Arduino Lint has suggestions for possible improvements to https://github.com/PervasiveDisplays/Pervasive_Wide_Medium: |
|
Arduino Lint has suggestions for possible improvements to https://github.com/rei-vilo/PDLS_Common: |
|
Arduino Lint has suggestions for possible improvements to https://github.com/rei-vilo/PDLS_Basic: |
|
Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index. The library(s) will be available for installation via Library Manager within a day's time. You can check the logs from the Library Manager indexer for your library(s) here: |
rei-vilo/PDLS_Basic
rei-vilo/PDLS_Common
PervasiveDisplays/Pervasive_Wide_Medium