Skip to content

Conversation

@JagritThukral
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Feb 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

ERROR: Arduino Lint found errors with https://github.com/JagritThukral/ubidots-mqtt-esp32/:

Linting library in ubidots-mqtt-esp32
INFO: No header file found matching library name (Ubidots_MQTT_for_ESP32___ESP8266.h). Best practices are for primary   
      header filename to match library name.                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Prohibited character(s) in library.properties name value: Ubidots MQTT for ESP32 + ESP8266            
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP011)                                                                                          
WARNING: library.properties name Ubidots MQTT for ESP32 + ESP8266 contains spaces. Although supported, best practices is
         to not use spaces.                                                                                             
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/publish

Linter results for project: no errors or warnings

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/publishNonBlocking

Linter results for project: no errors or warnings

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/subscribe

Linter results for project: no errors or warnings

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/subscribe_and_publish

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @JagritThukral
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@JagritThukral
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

ERROR: Arduino Lint found errors with https://github.com/JagritThukral/ubidots-mqtt-esp32/:

Linting library in ubidots-mqtt-esp32
INFO: No header file found matching library name (Ubidots_MQTT_for_ESP32___ESP8266.h). Best practices are for primary   
      header filename to match library name.                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Prohibited character(s) in library.properties name value: Ubidots MQTT for ESP32 + ESP8266            
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP011)                                                                                          
WARNING: library.properties name Ubidots MQTT for ESP32 + ESP8266 contains spaces. Although supported, best practices is
         to not use spaces.                                                                                             
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/publish

Linter results for project: no errors or warnings

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/publishNonBlocking

Linter results for project: no errors or warnings

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/subscribe

Linter results for project: no errors or warnings

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/subscribe_and_publish

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @JagritThukral
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@JagritThukral
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/JagritThukral/ubidots-mqtt-esp32/:

Linting library in ubidots-mqtt-esp32
INFO: No header file found matching library name (Ubidots_MQTT_for_ESP32_and_ESP8266.h). Best practices are for primary 
      header filename to match library name.                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Ubidots MQTT for ESP32 and ESP8266 is longer than the recommended length of 32   
         characters.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
WARNING: library.properties name Ubidots MQTT for ESP32 and ESP8266 contains spaces. Although supported, best practices 
         is to not use spaces.                                                                                          
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/publish

Linter results for project: no errors or warnings

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/publishNonBlocking

Linter results for project: no errors or warnings

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/subscribe

Linter results for project: no errors or warnings

-------------------

Linting sketch in ubidots-mqtt-esp32/examples/subscribe_and_publish

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot merged commit f757af2 into arduino:main Feb 1, 2025
14 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/JagritThukral/ubidots-mqtt-esp32/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant