Reduce cyclomatic complexity of ReportSizeDeltas.get_json_response()

The cyclomatic complexity of this function exceeded the maximum of 10.

To resolve this, the page count determination code was moved to a separate function.

Author: per1234

reportsizedeltas.py

@@ -306,21 +306,11 @@ def get_json_response(self, url):
                 page_count = 0
                 additional_pages = False
             else:
-                page_count = 1
-                additional_pages = False
-
-                if response_data["headers"]["Link"] is not None:
-                    # Get the pagination data
-                    if response_data["headers"]["Link"].find(">; rel=\"next\"") != -1:
-                        additional_pages = True
-                    for link in response_data["headers"]["Link"].split(","):
-                        if link[-13:] == ">; rel=\"last\"":
-                            link = re.split("[?&>]", link)
-                            for parameter in link:
-                                if parameter[:5] == "page=":
-                                    page_count = int(parameter.split("=")[1])
-                                    break
-                            break
+                page_count = get_page_count(link_header=response_data["headers"]["Link"])
+                if page_count > 1:
+                    additional_pages = True
+                else:
+                    additional_pages = False
 
             return {"json_data": json_data, "additional_pages": additional_pages, "page_count": page_count}
         except Exception as exception:
@@ -443,6 +433,26 @@ def determine_urlopen_retry(exception):
     return False
 
 
+def get_page_count(link_header):
+    """Return the number of pages of the API response
+
+    Keyword arguments:
+    link_header -- Link header of the HTTP response
+    """
+    page_count = 1
+    if link_header is not None:
+        # Get the pagination data
+        for link in link_header.split(","):
+            if link[-13:] == ">; rel=\"last\"":
+                link = re.split("[?&>]", link)
+                for parameter in link:
+                    if parameter[:5] == "page=":
+                        page_count = int(parameter.split("=")[1])
+                        break
+                break
+    return page_count
+
+
 def generate_value_cell(value):
     """Return the Markdown formatted text for a memory change data cell in the report table
 

tests/test_reportsizedeltas.py

@@ -415,6 +415,14 @@ def test_determine_urlopen_retry_false(self):
         self.assertFalse(reportsizedeltas.determine_urlopen_retry(
             exception=urllib.error.HTTPError(None, 404, "Not Found", None, None)))
 
+    # @unittest.skip("")
+    def test_get_page_count(self):
+        page_count = 4
+        link_header = ('<https://api.github.com/repositories/919161/pulls?page=2>; rel="next", '
+                       '"<https://api.github.com/repositories/919161/pulls?page=' + str(page_count) + '>; rel="last"')
+
+        self.assertEqual(page_count, reportsizedeltas.get_page_count(link_header=link_header))
+
     # @unittest.skip("")
     def test_generate_value_cell(self):
         self.assertEqual(" | :small_red_triangle: +42", reportsizedeltas.generate_value_cell(42))