Skip to content

Commit a0177c8

Browse files
committed
Remove/replace unittest.skip() decorators
- Remove the commented decorators. - Replace the decorator in use.
1 parent d4f26d9 commit a0177c8

File tree

1 file changed

+1
-16
lines changed

1 file changed

+1
-16
lines changed

tests/test_reportsizedeltas.py

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,12 @@ class TestReportsizedeltas(unittest.TestCase):
1616

1717
reportsizedeltas.set_verbosity(enable_verbosity=False)
1818

19-
# @unittest.skip("")
2019
def test_set_verbosity(self):
2120
with pytest.raises(TypeError):
2221
reportsizedeltas.set_verbosity(enable_verbosity=2)
2322
reportsizedeltas.set_verbosity(enable_verbosity=True)
2423
reportsizedeltas.set_verbosity(enable_verbosity=False)
2524

26-
# @unittest.skip("")
2725
def test_report_size_deltas(self):
2826
repository_name = "test_name/test_repo"
2927
artifact_download_url = "test_artifact_download_url"
@@ -90,7 +88,6 @@ def test_report_size_deltas(self):
9088
report_list = report_list + [{"pr_number": pr_data["number"], "report": report["data"]}]
9189
assert report_list == report_size_deltas.report_size_deltas()
9290

93-
# @unittest.skip("")
9491
def test_report_exists(self):
9592
repository_name = "test_name/test_repo"
9693
artifact_name = "test_artifact_name"
@@ -113,7 +110,6 @@ def test_report_exists(self):
113110

114111
assert not report_size_deltas.report_exists(pr_number=pr_number, pr_head_sha="asdf")
115112

116-
# @unittest.skip("")
117113
def test_get_artifact_download_url_for_sha(self):
118114
repository_name = "test_name/test_repo"
119115
pr_user_login = "test_pr_user_login"
@@ -161,7 +157,6 @@ def test_get_artifact_download_url_for_sha(self):
161157

162158
report_size_deltas.get_artifact_download_url_for_run.assert_called_once_with(run_id=run_id)
163159

164-
# @unittest.skip("")
165160
def test_get_artifact_download_url_for_run(self):
166161
repository_name = "test_name/test_repo"
167162
artifact_name = "test_artifact_name"
@@ -197,7 +192,6 @@ def test_get_artifact_download_url_for_run(self):
197192
# # TODO
198193
# def test_get_artifact(self):
199194

200-
# @unittest.skip("")
201195
def test_generate_report(self):
202196
pr_head_sha = "asdf123"
203197
pr_number = 42
@@ -262,7 +256,6 @@ def test_generate_report(self):
262256
'sketch': 'examples/ConnectionHandlerDemo'}]
263257
assert report_data == report["data"]
264258

265-
# @unittest.skip("")
266259
def test_comment_report(self):
267260
pr_number = 42
268261
report_markdown = "test_report_markdown"
@@ -284,7 +277,6 @@ def test_comment_report(self):
284277
+ str(pr_number) + "/comments",
285278
data=report_data)
286279

287-
# @unittest.skip("")
288280
def test_api_request(self):
289281
response_data = {"json_data": {"foo": "bar"},
290282
"additional_pages": False,
@@ -304,7 +296,6 @@ def test_api_request(self):
304296
url="https://api.github.com/" + request + "?" + request_parameters
305297
+ "&page=" + str(page_number) + "&per_page=100")
306298

307-
# @unittest.skip("")
308299
def test_get_json_response(self):
309300
response = {"headers": {"Link": None}, "body": "[]"}
310301
url = "test_url"
@@ -340,7 +331,6 @@ def test_get_json_response(self):
340331
assert response_data["additional_pages"]
341332
assert 4 == response_data["page_count"]
342333

343-
# @unittest.skip("")
344334
def test_http_request(self):
345335
url = "test_url"
346336
data = "test_data"
@@ -353,7 +343,6 @@ def test_http_request(self):
353343

354344
report_size_deltas.raw_http_request.assert_called_once_with(url=url, data=data)
355345

356-
# @unittest.skip("")
357346
def test_raw_http_request(self):
358347
user_name = "test_user"
359348
repo_name = "test_repo"
@@ -391,7 +380,6 @@ def test_raw_http_request(self):
391380

392381
urllib.request.urlopen.assert_called_once_with(url=request)
393382

394-
# @unittest.skip("")
395383
def test_handle_rate_limiting(self):
396384
report_size_deltas = reportsizedeltas.ReportSizeDeltas(repository_name="foo", artifact_name="foo", token="foo")
397385

@@ -406,25 +394,22 @@ def test_handle_rate_limiting(self):
406394
json_data["json_data"]["resources"]["core"]["remaining"] = 42
407395
report_size_deltas.handle_rate_limiting()
408396

409-
@unittest.skip("disabled because it causes a delay")
397+
@pytest.mark.slow(reason="Causes a delay")
410398
def test_determine_urlopen_retry_true(self):
411399
assert reportsizedeltas.determine_urlopen_retry(
412400
exception=urllib.error.HTTPError(None, 502, "Bad Gateway", None, None))
413401

414-
# @unittest.skip("")
415402
def test_determine_urlopen_retry_false(self):
416403
assert not reportsizedeltas.determine_urlopen_retry(
417404
exception=urllib.error.HTTPError(None, 404, "Not Found", None, None))
418405

419-
# @unittest.skip("")
420406
def test_get_page_count(self):
421407
page_count = 4
422408
link_header = ('<https://api.github.com/repositories/919161/pulls?page=2>; rel="next", '
423409
'"<https://api.github.com/repositories/919161/pulls?page=' + str(page_count) + '>; rel="last"')
424410

425411
assert page_count == reportsizedeltas.get_page_count(link_header=link_header)
426412

427-
# @unittest.skip("")
428413
def test_generate_value_cell(self):
429414
assert " | :small_red_triangle: +42" == reportsizedeltas.generate_value_cell(42)
430415
assert " | 0" == reportsizedeltas.generate_value_cell(0)

0 commit comments

Comments
 (0)