Skip to content

Commit bac374b

Browse files
committed
Use line break before binary operators in Python code
PEP 8 recommends line break before binary operators.
1 parent acfcf63 commit bac374b

File tree

2 files changed

+33
-33
lines changed

2 files changed

+33
-33
lines changed

reportsizedeltas.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,8 @@ def report_exists(self, pr_number, pr_head_sha):
121121
page_number = 1
122122
page_count = 1
123123
while page_number <= page_count:
124-
api_data = self.api_request(request="repos/" + self.repository_name + "/issues/" + str(pr_number) +
125-
"/comments",
124+
api_data = self.api_request(request="repos/" + self.repository_name + "/issues/" + str(pr_number)
125+
+ "/comments",
126126
page_number=page_number)
127127

128128
comments_data = api_data["json_data"]
@@ -150,8 +150,8 @@ def get_artifact_download_url_for_sha(self, pr_user_login, pr_head_ref, pr_head_
150150
page_count = 1
151151
while page_number <= page_count:
152152
api_data = self.api_request(request="repos/" + self.repository_name + "/actions/runs",
153-
request_parameters="actor=" + pr_user_login + "&branch=" + pr_head_ref +
154-
"&event=pull_request&status=completed",
153+
request_parameters="actor=" + pr_user_login + "&branch=" + pr_head_ref
154+
+ "&event=pull_request&status=completed",
155155
page_number=page_number)
156156
runs_data = api_data["json_data"]
157157

@@ -179,8 +179,8 @@ def get_artifact_download_url_for_run(self, run_id):
179179
page_number = 1
180180
page_count = 1
181181
while page_number <= page_count:
182-
api_data = self.api_request(request="repos/" + self.repository_name + "/actions/runs/" +
183-
str(run_id) + "/artifacts",
182+
api_data = self.api_request(request="repos/" + self.repository_name + "/actions/runs/"
183+
+ str(run_id) + "/artifacts",
184184
page_number=page_number)
185185
artifacts_data = api_data["json_data"]
186186

@@ -230,19 +230,19 @@ def generate_report(self, artifact_folder_object, pr_head_sha, pr_number):
230230
artifact_folder_object -- object containing the data about the temporary folder that stores the markdown files
231231
"""
232232
with artifact_folder_object as artifact_folder:
233-
report_markdown = (self.report_key_beginning + pr_head_sha + "]" +
234-
"(https://github.com/" + self.repository_name + "/pull/" + str(pr_number) +
235-
"/commits/" + pr_head_sha + ")**\n\n")
233+
report_markdown = (self.report_key_beginning + pr_head_sha + "]"
234+
+ "(https://github.com/" + self.repository_name + "/pull/" + str(pr_number)
235+
+ "/commits/" + pr_head_sha + ")**\n\n")
236236
report_markdown = report_markdown + "FQBN | Flash Usage | RAM For Global Variables\n---|---|---"
237237
reports_data = []
238238
for report_filename in sorted(os.listdir(path=artifact_folder)):
239239
with open(file=artifact_folder + "/" + report_filename) as report_file:
240240
report_data = json.load(report_file)
241241
reports_data = reports_data + [report_data]
242-
report_markdown = (report_markdown + "\n" +
243-
report_data["fqbn"] +
244-
generate_value_cell(report_data["flash_delta"]) +
245-
generate_value_cell(report_data["ram_delta"]))
242+
report_markdown = (report_markdown + "\n"
243+
+ report_data["fqbn"]
244+
+ generate_value_cell(report_data["flash_delta"])
245+
+ generate_value_cell(report_data["ram_delta"]))
246246

247247
logger.debug("Report:\n" + report_markdown)
248248
return {"markdown": report_markdown, "data": reports_data}
@@ -257,11 +257,11 @@ def comment_report(self, pr_number, report_markdown):
257257
report_data = {"body": report_markdown}
258258
report_data = json.dumps(obj=report_data)
259259
report_data = report_data.encode(encoding="utf-8")
260-
url = ("https://api.github.com/repos/" +
261-
self.repository_name +
262-
"/issues/" +
263-
str(pr_number) +
264-
"/comments")
260+
url = ("https://api.github.com/repos/"
261+
+ self.repository_name
262+
+ "/issues/"
263+
+ str(pr_number)
264+
+ "/comments")
265265

266266
self.http_request(url=url, data=report_data)
267267

@@ -278,8 +278,8 @@ def api_request(self, request, request_parameters="", page_number=1):
278278
page_number -- Some responses will be paginated. This argument specifies which page should be returned.
279279
(default value: 1)
280280
"""
281-
return self.get_json_response(url="https://api.github.com/" + request + "?" + request_parameters + "&page=" +
282-
str(page_number) + "&per_page=100")
281+
return self.get_json_response(url="https://api.github.com/" + request + "?" + request_parameters + "&page="
282+
+ str(page_number) + "&per_page=100")
283283

284284
def get_json_response(self, url):
285285
"""Load the specified URL and return a dictionary:

tests/test_reportsizedeltas.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ def test_report_exists(self):
9999

100100
self.assertTrue(report_size_deltas.report_exists(pr_number=pr_number, pr_head_sha=pr_head_sha))
101101

102-
report_size_deltas.api_request.assert_called_once_with(request="repos/" + repository_name + "/issues/" +
103-
str(pr_number) + "/comments",
102+
report_size_deltas.api_request.assert_called_once_with(request="repos/" + repository_name + "/issues/"
103+
+ str(pr_number) + "/comments",
104104
page_number=1)
105105

106106
self.assertFalse(report_size_deltas.report_exists(pr_number=pr_number, pr_head_sha="asdf"))
@@ -129,8 +129,8 @@ def test_get_artifact_download_url_for_sha(self):
129129

130130
# Test pagination
131131
request = "repos/" + repository_name + "/actions/runs"
132-
request_parameters = ("actor=" + pr_user_login + "&branch=" + pr_head_ref +
133-
"&event=pull_request&status=completed")
132+
request_parameters = ("actor=" + pr_user_login + "&branch=" + pr_head_ref
133+
+ "&event=pull_request&status=completed")
134134
calls = [unittest.mock.call(request=request, request_parameters=request_parameters, page_number=1),
135135
unittest.mock.call(request=request, request_parameters=request_parameters, page_number=2),
136136
unittest.mock.call(request=request, request_parameters=request_parameters, page_number=3)]
@@ -170,8 +170,8 @@ def test_get_artifact_download_url_for_run(self):
170170
self.assertEqual(archive_download_url, report_size_deltas.get_artifact_download_url_for_run(run_id=run_id))
171171

172172
report_size_deltas.api_request.assert_called_once_with(
173-
request="repos/" + repository_name + "/actions/runs/" + str(run_id) +
174-
"/artifacts",
173+
request="repos/" + repository_name + "/actions/runs/" + str(run_id)
174+
+ "/artifacts",
175175
page_number=1)
176176

177177
json_data = {"artifacts": [{"name": "foo123", "archive_download_url": "test_artifact_url"},
@@ -204,9 +204,9 @@ def test_generate_report(self):
204204
report = report_size_deltas.generate_report(artifact_folder_object=artifact_folder_object,
205205
pr_head_sha=pr_head_sha, pr_number=pr_number)
206206
report_markdown = (
207-
report_size_deltas.report_key_beginning + pr_head_sha +
208-
"](https://github.com/" + repository_name + "/pull/" + str(pr_number) + "/commits/" + pr_head_sha +
209-
")**\n\n"
207+
report_size_deltas.report_key_beginning + pr_head_sha
208+
+ "](https://github.com/" + repository_name + "/pull/" + str(pr_number) + "/commits/" + pr_head_sha
209+
+ ")**\n\n"
210210
"FQBN | Flash Usage | RAM For Global Variables\n"
211211
"---|---|---\n"
212212
"adafruit:samd:adafruit_feather_m0 | 0 | N/A\n"
@@ -266,8 +266,8 @@ def test_comment_report(self):
266266
report_data = report_data.encode(encoding="utf-8")
267267

268268
report_size_deltas.http_request.assert_called_once_with(
269-
url="https://api.github.com/repos/" + repository_name + "/issues/" +
270-
str(pr_number) + "/comments",
269+
url="https://api.github.com/repos/" + repository_name + "/issues/"
270+
+ str(pr_number) + "/comments",
271271
data=report_data)
272272

273273
# @unittest.skip("")
@@ -287,8 +287,8 @@ def test_api_request(self):
287287
request_parameters=request_parameters,
288288
page_number=page_number))
289289
report_size_deltas.get_json_response.assert_called_once_with(
290-
url="https://api.github.com/" + request + "?" + request_parameters +
291-
"&page=" + str(page_number) + "&per_page=100")
290+
url="https://api.github.com/" + request + "?" + request_parameters
291+
+ "&page=" + str(page_number) + "&per_page=100")
292292

293293
# @unittest.skip("")
294294
def test_get_json_response(self):

0 commit comments

Comments
 (0)