relax hid host enumeration, allow set protocol to be stalled

hathach · hathach · commit 878f2b54fe20 · 2023-03-21T18:12:55.000+07:00
diff --git a/src/class/hid/hid_host.c b/src/class/hid/hid_host.c
@@ -465,8 +465,10 @@ bool hidh_set_config(uint8_t dev_addr, uint8_t itf_num)
 
 static void process_set_config(tuh_xfer_t* xfer)
 {
-  // Stall is a valid response for SET_IDLE, therefore we could ignore its result
-  if ( xfer->setup->bRequest != HID_REQ_CONTROL_SET_IDLE )
+  // Stall is a valid response for SET_IDLE, sometime SET_PROTOCOL as well
+  // therefore we could ignore its result
+  if ( !(xfer->setup->bRequest == HID_REQ_CONTROL_SET_IDLE ||
+         xfer->setup->bRequest == HID_REQ_CONTROL_SET_PROTOCOL) )
   {
     TU_ASSERT(xfer->result == XFER_RESULT_SUCCESS, );
   }

Original file line number	Diff line number	Diff line change
`@@ -465,8 +465,10 @@ bool hidh_set_config(uint8_t dev_addr, uint8_t itf_num)`
`465`	`465`
`466`	`466`	`static void process_set_config(tuh_xfer_t* xfer)`
`467`	`467`	`{`
`468`		`- // Stall is a valid response for SET_IDLE, therefore we could ignore its result`
`469`		`- if ( xfer->setup->bRequest != HID_REQ_CONTROL_SET_IDLE )`
	`468`	`+ // Stall is a valid response for SET_IDLE, sometime SET_PROTOCOL as well`
	`469`	`+ // therefore we could ignore its result`
	`470`	`+ if ( !(xfer->setup->bRequest == HID_REQ_CONTROL_SET_IDLE \|\|`
	`471`	`+ xfer->setup->bRequest == HID_REQ_CONTROL_SET_PROTOCOL) )`
`470`	`472`	`{`
`471`	`473`	`TU_ASSERT(xfer->result == XFER_RESULT_SUCCESS, );`
`472`	`474`	`}`