Skip to content

Commit d1ea384

Browse files
committed
rename TU_LOG_VAR to TU_LOG_PTR, print out setup of failed control transfer when LOG=1
1 parent 37529c4 commit d1ea384

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

src/common/tusb_debug.h

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ static inline void tu_print_arr(uint8_t const* buf, uint32_t bufsize)
6666
#define TU_LOG(n, ...) TU_XSTRCAT(TU_LOG, n)(__VA_ARGS__)
6767
#define TU_LOG_MEM(n, ...) TU_XSTRCAT3(TU_LOG, n, _MEM)(__VA_ARGS__)
6868
#define TU_LOG_ARR(n, ...) TU_XSTRCAT3(TU_LOG, n, _ARR)(__VA_ARGS__)
69-
#define TU_LOG_VAR(n, ...) TU_XSTRCAT3(TU_LOG, n, _VAR)(__VA_ARGS__)
69+
#define TU_LOG_PTR(n, ...) TU_XSTRCAT3(TU_LOG, n, _PTR)(__VA_ARGS__)
7070
#define TU_LOG_INT(n, ...) TU_XSTRCAT3(TU_LOG, n, _INT)(__VA_ARGS__)
7171
#define TU_LOG_HEX(n, ...) TU_XSTRCAT3(TU_LOG, n, _HEX)(__VA_ARGS__)
7272
#define TU_LOG_LOCATION() tu_printf("%s: %d:\r\n", __PRETTY_FUNCTION__, __LINE__)
@@ -76,7 +76,7 @@ static inline void tu_print_arr(uint8_t const* buf, uint32_t bufsize)
7676
#define TU_LOG1 tu_printf
7777
#define TU_LOG1_MEM tu_print_mem
7878
#define TU_LOG1_ARR(_x, _n) tu_print_arr((uint8_t const*)(_x), _n)
79-
#define TU_LOG1_VAR(_x) tu_print_arr((uint8_t const*)(_x), sizeof(*(_x)))
79+
#define TU_LOG1_PTR(_x) tu_print_arr((uint8_t const*)(_x), sizeof(*(_x)))
8080
#define TU_LOG1_INT(_x) tu_printf(#_x " = %ld\r\n", (unsigned long) (_x) )
8181
#define TU_LOG1_HEX(_x) tu_printf(#_x " = %lX\r\n", (unsigned long) (_x) )
8282

@@ -85,7 +85,7 @@ static inline void tu_print_arr(uint8_t const* buf, uint32_t bufsize)
8585
#define TU_LOG2 TU_LOG1
8686
#define TU_LOG2_MEM TU_LOG1_MEM
8787
#define TU_LOG2_ARR TU_LOG1_ARR
88-
#define TU_LOG2_VAR TU_LOG1_VAR
88+
#define TU_LOG2_PTR TU_LOG1_PTR
8989
#define TU_LOG2_INT TU_LOG1_INT
9090
#define TU_LOG2_HEX TU_LOG1_HEX
9191
#endif
@@ -95,7 +95,7 @@ static inline void tu_print_arr(uint8_t const* buf, uint32_t bufsize)
9595
#define TU_LOG3 TU_LOG1
9696
#define TU_LOG3_MEM TU_LOG1_MEM
9797
#define TU_LOG3_ARR TU_LOG1_ARR
98-
#define TU_LOG3_VAR TU_LOG1_VAR
98+
#define TU_LOG3_PTR TU_LOG1_PTR
9999
#define TU_LOG3_INT TU_LOG1_INT
100100
#define TU_LOG3_HEX TU_LOG1_HEX
101101
#endif
@@ -132,7 +132,7 @@ static inline const char* tu_lookup_find(tu_lookup_table_t const* p_table, uint3
132132
#ifndef TU_LOG
133133
#define TU_LOG(n, ...)
134134
#define TU_LOG_MEM(n, ...)
135-
#define TU_LOG_VAR(n, ...)
135+
#define TU_LOG_PTR(n, ...)
136136
#define TU_LOG_INT(n, ...)
137137
#define TU_LOG_HEX(n, ...)
138138
#define TU_LOG_LOCATION()
@@ -143,30 +143,30 @@ static inline const char* tu_lookup_find(tu_lookup_table_t const* p_table, uint3
143143

144144
#define TU_LOG0(...)
145145
#define TU_LOG0_MEM(...)
146-
#define TU_LOG0_VAR(...)
146+
#define TU_LOG0_PTR(...)
147147
#define TU_LOG0_INT(...)
148148
#define TU_LOG0_HEX(...)
149149

150150
#ifndef TU_LOG1
151151
#define TU_LOG1(...)
152152
#define TU_LOG1_MEM(...)
153-
#define TU_LOG1_VAR(...)
153+
#define TU_LOG1_PTR(...)
154154
#define TU_LOG1_INT(...)
155155
#define TU_LOG1_HEX(...)
156156
#endif
157157

158158
#ifndef TU_LOG2
159159
#define TU_LOG2(...)
160160
#define TU_LOG2_MEM(...)
161-
#define TU_LOG2_VAR(...)
161+
#define TU_LOG2_PTR(...)
162162
#define TU_LOG2_INT(...)
163163
#define TU_LOG2_HEX(...)
164164
#endif
165165

166166
#ifndef TU_LOG3
167167
#define TU_LOG3(...)
168168
#define TU_LOG3_MEM(...)
169-
#define TU_LOG3_VAR(...)
169+
#define TU_LOG3_PTR(...)
170170
#define TU_LOG3_INT(...)
171171
#define TU_LOG3_HEX(...)
172172
#endif

src/host/usbh.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,7 @@ bool tuh_control_xfer (tuh_xfer_t* xfer)
540540
const uint8_t rhport = usbh_get_rhport(daddr);
541541

542542
TU_LOG2("[%u:%u] %s: ", rhport, daddr, xfer->setup->bRequest <= TUSB_REQ_SYNCH_FRAME ? tu_str_std_request[xfer->setup->bRequest] : "Unknown Request");
543-
TU_LOG2_VAR(xfer->setup);
543+
TU_LOG2_PTR(xfer->setup);
544544
TU_LOG2("\r\n");
545545

546546
if (xfer->complete_cb)
@@ -618,7 +618,11 @@ static bool usbh_control_xfer_cb (uint8_t dev_addr, uint8_t ep_addr, xfer_result
618618

619619
if (XFER_RESULT_SUCCESS != result)
620620
{
621-
TU_LOG1("[%u:%u] Control %s\r\n", rhport, dev_addr, result == XFER_RESULT_STALLED ? "STALLED" : "FAILED");
621+
TU_LOG1("[%u:%u] Control %s, xferred_bytes = %lu\r\n", rhport, dev_addr, result == XFER_RESULT_STALLED ? "STALLED" : "FAILED", xferred_bytes);
622+
#if CFG_TUSB_DEBUG == 1
623+
TU_LOG1_PTR(request);
624+
TU_LOG1("\r\n");
625+
#endif
622626

623627
// terminate transfer if any stage failed
624628
_xfer_complete(dev_addr, result);

0 commit comments

Comments
 (0)