Skip to content

Commit 0e7f6c1

Browse files
authored
Merge pull request #647 from per1234/improve-messages
Improve precomposed asset installation commit and PR messages
2 parents d0e5e63 + 039c587 commit 0e7f6c1

18 files changed

+145
-111
lines changed

workflow-templates/check-action-metadata-task.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,17 +76,17 @@ Define the `{repository-owner}` and `{repository-name}` attributes and use them
7676
```text
7777
Add CI workflow to validate action.yml
7878

79-
A task and GitHub Actions workflow are provided here for validating the action.yml metadata file of GitHub Actions
80-
actions.
79+
A task and GitHub Actions workflow are provided here to check for problems in the `action.yml` metadata file of GitHub Actions actions by validating it against the JSON schema.
8180

82-
On every push or pull request that affects the metadata file, and periodically, validate action.yml against its JSON
83-
schema.
81+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that
82+
changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also
83+
triggered periodically, in order to catch breakage caused by external changes.
8484
```
8585

8686
## PR message
8787

8888
```markdown
89-
A task and GitHub Actions workflow are provided here for validating the [`action.yml`](https://docs.github.com/actions/creating-actions/metadata-syntax-for-github-actions) metadata file of [GitHub Actions actions](https://docs.github.com/actions/learn-github-actions/understanding-github-actions#actions).
89+
A task and GitHub Actions workflow are provided here to check for problems in the [`action.yml`](https://docs.github.com/actions/creating-actions/metadata-syntax-for-github-actions) metadata file of [GitHub Actions actions](https://docs.github.com/actions/learn-github-actions/understanding-github-actions#actions) by validating it against [the JSON schema](https://json.schemastore.org/github-action.json).
9090

91-
On every push or pull request that affects the metadata file, and periodically, validate `action.yml` against [its JSON schema](https://json.schemastore.org/github-action.json).
91+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also triggered periodically, in order to catch breakage caused by external changes.
9292
```

workflow-templates/check-files-task.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ Tasks are also added to check for problems with symbolic links ("symlinks") cont
6161
- Broken symlinks
6262
- Circular symlinks
6363
64-
A GitHub Actions workflow is included to run the tasks on any change to the project files in order to avoid the
65-
introduction of problems with the project filesystem, and periodically in order to catch breakage caused by external
66-
changes.
64+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that
65+
changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also
66+
triggered periodically, in order to catch breakage caused by external changes.
6767
```
6868

6969
## PR message
@@ -81,5 +81,5 @@ Tasks are also added to check for problems with symbolic links ("symlinks") cont
8181
- Broken symlinks
8282
- Circular symlinks
8383
84-
A GitHub Actions workflow is included to run the tasks on any change to the project files in order to avoid the introduction of problems with the project filesystem, and periodically in order to catch breakage caused by external changes.
84+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also triggered periodically, in order to catch breakage caused by external changes.
8585
```

workflow-templates/check-general-formatting-task.md

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,23 @@ Define the `{repository-owner}` and `{repository-name}` attributes and use them
4949
## Commit message
5050

5151
```
52-
Add CI workflow to check general file formatting
52+
Add infrastructure for checking general file formatting
5353

54-
On every push, pull request, and periodically, check whether the repository's files are formatted according to
55-
.editorconfig.
54+
The project's .editorconfig file defines the fundamental formatting style for use in the project files.
55+
56+
A task is added to use the "editorconfig-checker" tool to verify the formatting of the project files is compliant.
57+
58+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that
59+
changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also
60+
triggered periodically, in order to catch breakage caused by external changes.
5661
```
5762
5863
## PR message
5964
6065
```markdown
61-
On every push, pull request, and periodically, use [editorconfig-checker](https://github.com/editorconfig-checker/editorconfig-checker) check whether the repository's files are formatted according to [`.editorconfig`](https://editorconfig.org/).
66+
The project's [`.editorconfig`](https://editorconfig.org/) file defines the fundamental formatting style for use in the project files.
67+
68+
A task is added to use the [**editorconfig-checker**](https://github.com/editorconfig-checker/editorconfig-checker) tool to verify the formatting of the project files is compliant.
69+
70+
A GitHub Actions workflow is included to automatically run the task. The workflow is triggered on any push or pull that changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also triggered periodically, in order to catch breakage caused by external changes.
6271
```

workflow-templates/check-go-dependencies-task.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,11 @@ An updated cache is also generated whenever the cache is found to be outdated by
112112
## Commit message
113113

114114
```
115-
Add CI workflow to check for unapproved Go dependency licenses
115+
Add infrastructure to check for unapproved Go dependency licenses
116116

117-
A task and GitHub Actions workflow are provided here for checking the license types of Go project dependencies.
117+
Tasks and a GitHub Actions workflow are added for checking the license types of Go project dependencies.
118118

119-
On every push and pull request that affects relevant files, the CI workflow will check:
119+
On every push and pull request that affects relevant files, the CI workflow will run the tasks to check:
120120

121121
- If the dependency licenses cache is up to date
122122
- If any of the project's dependencies have an unapproved license type.

workflow-templates/check-go-dependencies-task.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868
with:
6969
submodules: recursive
7070

71-
# This is required to allow licensee/setup-licensed to install licensed via Ruby gem.
71+
# This is required to allow licensee/setup-licensed to install Licensed via Ruby gem.
7272
- name: Install Ruby
7373
uses: ruby/setup-ruby@v1
7474
with:
@@ -135,7 +135,7 @@ jobs:
135135
with:
136136
submodules: recursive
137137

138-
# This is required to allow licensee/setup-licensed to install licensed via Ruby gem.
138+
# This is required to allow licensee/setup-licensed to install Licensed via Ruby gem.
139139
- name: Install Ruby
140140
uses: ruby/setup-ruby@v1
141141
with:

workflow-templates/check-go-task.md

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Install the [`check-go-task.yml`](check-go-task.yml) GitHub Actions workflow to
1414
- Install to: repository root (or merge into the existing `Taskfile.yml`).
1515
- [`.golangci.yml`](assets/go/.golangci.yml) - Contains all the go-linting configurations.
1616
- Install to: repository root as `.golangci.yml`
17-
- [`Taskfile.yml`](assets/go-task/Taskfile.yml) - `DEFAULT_GO_MODULE_PATH` and `DEFAULT_GO_PACKAGES` variables
17+
- [`Taskfile.yml`](assets/go-task/Taskfile.yml) - `DEFAULT_GO_MODULE_PATH` and `DEFAULT_GO_PACKAGES` variables.
1818
- Merge into `Taskfile.yml`
1919

2020
### Configuration
@@ -50,25 +50,19 @@ Define the `{repository-owner}` and `{repository-name}` attributes and use them
5050
## Commit message
5151

5252
```
53-
Add CI workflow to lint and check formatting of Go code
53+
Add infrastructure to lint and format Go code
5454

55-
On every push and pull request that affects relevant files, check the Go module for:
55+
Tasks are provided to format and check for problems in the project's Go modules.
5656

57-
- Common detectable errors in the code.
58-
- Use of outdated APIs
59-
- Code style violations
60-
- Code formatting inconsistency
61-
- Misconfiguration
57+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that
58+
changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also
59+
triggered periodically, in order to catch breakage caused by external changes.
6260
```
6361
6462
## PR message
6563
6664
```markdown
67-
On every push and pull request that affects relevant files, check the repository's [Go](https://golang.org/) module for:
65+
Tasks are provided to format and check for problems in the project's [Go](https://golang.org/) modules.
6866
69-
- Common detectable errors in the code.
70-
- Use of outdated APIs
71-
- Code style violations
72-
- Code formatting inconsistency
73-
- Misconfiguration
67+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also triggered periodically, in order to catch breakage caused by external changes.
7468
```

workflow-templates/check-javascript-task.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,20 +80,21 @@ Define the `{repository-owner}` and `{repository-name}` attributes and use them
8080
## Commit message
8181

8282
```
83-
Add CI workflow to lint JavaScript code
83+
Add infrastructure to lint JavaScript code
8484

85-
On every push and pull request that affects relevant files, and periodically, run ESLint on the repository's JavaScript
86-
files.
85+
A task is provided to run ESLint on the project's JavaScript files.
8786

88-
ESLint is configured via the .eslintrc.yml file:
89-
https://eslint.org/docs/latest/use/configure/configuration-files
87+
A GitHub Actions workflow is included to automatically run the task. The workflow is triggered on any push or pull that
88+
changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also
89+
triggered periodically, in order to catch breakage caused by external changes.
9090
```
9191
9292
## PR message
9393
9494
```markdown
95-
On every push and pull request that affects relevant files, and periodically, run [**ESLint**](https://eslint.org/) on the repository's JavaScript files.
95+
A task is provided to run [**ESLint**](https://eslint.org/) on the project's JavaScript files.
9696
97-
**ESLint** is configured via the `.eslintrc.yml` file:
98-
https://eslint.org/docs/latest/use/configure/configuration-files
97+
A GitHub Actions workflow is included to automatically run the task. The workflow is triggered on any push or pull that
98+
changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also
99+
triggered periodically, in order to catch breakage caused by external changes.
99100
```

workflow-templates/check-markdown-task.md

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -99,38 +99,27 @@ Define the `{repository-owner}` and `{repository-name}` attributes and use them
9999
## Commit message
100100

101101
```
102-
Add CI workflow to check Markdown files for problems
102+
Add infrastructure to check for problems in Markdown files
103103

104-
On every push and pull request that affects relevant files, and periodically, check the repository's Markdown files for
105-
problems:
104+
Tasks are provided to check for problems in the project's Markdown files:
106105

107106
- Use markdownlint to check for common problems and formatting.
108107
- Use markdown-link-check to check for broken links.
109108

110-
The Arduino tooling Markdown style is defined by the `.markdownlint.yml` file.
111-
112-
In the event the repository contains externally maintained Markdown files, markdownlint can be configured to ignore them
113-
via a `.markdownlintignore` file:
114-
https://github.com/igorshubovych/markdownlint-cli#ignoring-files
115-
116-
markdown-link-check is configured via the `.markdown-link-check.json` file:
117-
https://github.com/tcort/markdown-link-check#config-file-format
109+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that
110+
changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also
111+
triggered periodically, in order to catch breakage caused by external changes.
118112
```
119113
120114
## PR message
121115
122116
```markdown
123-
On every push and pull request that affects relevant files, and periodically, check the repository's Markdown files for
124-
problems:
117+
Add infrastructure to check for problems in Markdown files
118+
119+
Tasks are provided to check for problems in the project's Markdown files:
125120
126121
- Use [markdownlint-cli](https://github.com/igorshubovych/markdownlint-cli) to check for common problems and formatting.
127122
- Use [markdown-link-check](https://github.com/tcort/markdown-link-check) to check for broken links.
128123
129-
The Arduino tooling Markdown style is defined by the `.markdownlint.yml` file.
130-
131-
In the event the repository contains externally maintained Markdown files, markdownlint can be configured to ignore them via a `.markdownlintignore` file:
132-
https://github.com/igorshubovych/markdownlint-cli#ignoring-files
133-
134-
markdown-link-check is configured via the `.markdown-link-check.json` file:
135-
https://github.com/tcort/markdown-link-check#config-file-format
124+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also triggered periodically, in order to catch breakage caused by external changes.
136125
```

workflow-templates/check-npm-task.md

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,19 +63,25 @@ Define the `{repository-owner}` and `{repository-name}` attributes and use them
6363
## Commit message
6464

6565
```
66-
Add CI workflow to check for problems with npm configuration files
66+
Add infrastructure to check for problems with npm configuration files
6767

68-
On every push and pull request that affects relevant files, and periodically:
68+
Tasks are provided to check for problems in the project's npm configuration files:
6969

70-
- Validate package.json against its JSON schema.
71-
- Check for forgotten package-lock.json syncs.
70+
* Validate package.json against its JSON schema.
71+
* Check for forgotten package-lock.json syncs.
72+
73+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that
74+
changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also
75+
triggered periodically, in order to catch breakage caused by external changes.
7276
```
7377
7478
## PR message
7579
7680
```markdown
77-
On every push and pull request that affects relevant files, and periodically:
81+
Tasks are provided to check for problems in the project's npm configuration files:
7882
7983
- Validate [`package.json`](https://docs.npmjs.com/cli/v7/configuring-npm/package-json) against [its JSON schema](https://json.schemastore.org/package.json).
8084
- Check for forgotten [`package-lock.json`](https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json) syncs.
85+
86+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also triggered periodically, in order to catch breakage caused by external changes.
8187
```

workflow-templates/check-poetry-task.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,9 @@ The tasks provide the following operations:
5252
* Update the `poetry.lock` file as may be required following manual modifications to `pyproject.toml`, or update of the
5353
"Poetry" application
5454

55-
These tasks are executed by the GitHub Actions workflow on any push or pull request that modifies relevant files, and
56-
periodically to check for breakage caused by external changes.
55+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that
56+
changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also
57+
triggered periodically, in order to catch breakage caused by external changes.
5758
```
5859
5960
## PR message
@@ -68,5 +69,5 @@ The tasks provide the following operations:
6869
- Check for problems with the data structure of the [`pyproject.toml`](https://python-poetry.org/docs/pyproject/) Python project file
6970
- Update the `poetry.lock` file as may be required following manual modifications to `pyproject.toml`, or update of the **Poetry** application
7071
71-
These tasks are executed by the GitHub Actions workflow on any push or pull request that modifies relevant files, and periodically to check for breakage caused by external changes.
72+
A GitHub Actions workflow is included to automatically run the tasks. The workflow is triggered on any push or pull that changes relevant project files, in order to avoid the introduction of problems with the project filesystem. It is also triggered periodically, in order to catch breakage caused by external changes.
7273
```

0 commit comments

Comments
 (0)