drivers: video: ov7670: Implement missing video API functions

Add the missing stream_start and stream_stop API functions
(the driver doesn't work without them) and implement video
controls for horizontal mirror (hmirror) and vertical flip.

Signed-off-by: Ibrahim Abdalkader <[email protected]>

Author: iabdalkader

drivers/video/ov7670.c

@@ -9,6 +9,7 @@
 #include <zephyr/drivers/gpio.h>
 #include <zephyr/drivers/i2c.h>
 #include <zephyr/drivers/video.h>
+#include <zephyr/drivers/video-controls.h>
 #include <zephyr/logging/log.h>
 
 LOG_MODULE_REGISTER(video_ov7670, CONFIG_VIDEO_LOG_LEVEL);
@@ -181,6 +182,8 @@ const struct ov7670_resolution_cfg OV7670_RESOLUTION_VGA = {
 
 /* OV7670 definitions */
 #define OV7670_PROD_ID 0x76
+#define OV7670_MVFP_HFLIP 0x20
+#define OV7670_MVFP_VFLIP 0x10
 
 #define OV7670_VIDEO_FORMAT_CAP(width, height, format)                                             \
 	{                                                                                          \
@@ -204,7 +207,7 @@ static const struct video_format_cap fmts[] = {
  * Note that this table assumes the camera is fed a 6MHz XCLK signal
  */
 static const struct ov7670_reg ov7670_init_regtbl[] = {
-	{OV7670_MVFP, 0x20}, /* MVFP: Mirror/VFlip,Normal image */
+	{OV7670_MVFP, 0x00}, /* MVFP: Mirror/VFlip,Normal image */
 
 	/* configure the output timing */
 	/* PCLK does not toggle during horizontal blank, one PCLK, one pixel */
@@ -547,10 +550,39 @@ static int ov7670_init(const struct device *dev)
 	return 0;
 }
 
+static int ov7670_stream_start(const struct device *dev)
+{
+	return 0;
+}
+
+static int ov7670_stream_stop(const struct device *dev)
+{
+	return 0;
+}
+
+static int ov7670_set_ctrl(const struct device *dev, unsigned int cid, void *value)
+{
+	const struct ov7670_config *config = dev->config;
+
+	switch (cid) {
+	case VIDEO_CID_HFLIP:
+		return i2c_reg_update_byte_dt(&config->bus, OV7670_MVFP,
+			OV7670_MVFP_HFLIP, ((int)value) ? OV7670_MVFP_HFLIP : 0);
+	case VIDEO_CID_VFLIP:
+		return i2c_reg_update_byte_dt(&config->bus, OV7670_MVFP,
+			OV7670_MVFP_VFLIP, ((int)value) ? OV7670_MVFP_VFLIP : 0);
+	default:
+		return -ENOTSUP;
+	}
+}
+
 static DEVICE_API(video, ov7670_api) = {
 	.set_format = ov7670_set_fmt,
 	.get_format = ov7670_get_fmt,
 	.get_caps = ov7670_get_caps,
+	.stream_start = ov7670_stream_start,
+	.stream_stop = ov7670_stream_stop,
+	.set_ctrl = ov7670_set_ctrl,
 };
 
 #if DT_ANY_INST_HAS_PROP_STATUS_OKAY(reset_gpios)