github actions build failing on windows-x64

[MarkRivers]

I tried adding the DLL build for ADCore to .github/workflows/ci-scripts.yml. However, it fails with this error (I added line breaks to the output for readability):

link -nologo -subsystem:windows -dll -LTCG -incremental:no -opt:ref -release  -MACHINE:X64      -out:ADBase.dll -implib:ADBase.lib 
NDAttribute.obj NDAttributeList.obj NDArrayPool.obj NDArray.obj asynNDArrayDriver.obj ADDriver.obj paramAttribute.obj 
CCDMultiTrack.obj PVAttribute.obj functAttribute.obj parseAreaPrefixes.obj myTimeStampSource.obj myAttributeFunctions.obj        
C:/Users/runneradmin/.cache/asyn-master/lib/windows-x64/asyn.lib  C:/Users/runneradmin/.cache/base-7.0/lib/windows-x64/dbRecStd.lib
C:/Users/runneradmin/.cache/base-7.0/lib/windows-x64/dbCore.lib  C:/Users/runneradmin/.cache/base-7.0/lib/windows-x64/ca.lib  
C:/Users/runneradmin/.cache/base-7.0/lib/windows-x64/Com.lib xml2.lib
  LINK : fatal error LNK1181: cannot open input file 'xml2.lib'

xml2.lib is in ADSupport, but it is not prefixing xml2.lib with something like: C:/Users/runneradmin/.cache/adsupport/lib/windows-x64/
If I build locally I see this:

link -nologo -subsystem:windows -dll -LTCG -incremental:no -opt:ref -release  -MACHINE:X64      -out:ADBase.dll -implib:ADBase.lib     
NDAttribute.obj NDAttributeList.obj NDArrayPool.obj NDArray.obj asynNDArrayDriver.obj ADDriver.obj paramAttribute.obj 
CCDMultiTrack.obj PVAttribute.obj functAttribute.obj parseAreaPrefixes.obj myTimeStampSource.obj myAttributeFunctions.obj        
J:/epics/devel/asyn-4-45/lib/windows-x64/asyn.lib  H:/epics-devel/base-7.0.8/lib/windows-x64/dbRecStd.lib  
H:/epics-devel/base-7.0.8/lib/windows-x64/dbCore.lib  H:/epics-devel/base-7.0.8/lib/windows-x64/ca.lib  
H:/epics-devel/base-7.0.8/lib/windows-x64/Com.lib  J:/epics/devel/areaDetector-3-14/ADSupport/lib/windows-x64/xml2.lib
Creating library ADBase.lib and object ADBase.exp
Generating code
Finished generating code

The dynamic build is told that adsupport is a deps:

          - name: Win2022 Base7.0 DLL
            os: windows-2022
            cmp: vs2022
            configuration: default
            base: "7.0"
            deps: adsupport

How do I make it look for xml2.lib in ADSupport?

[FreddieAkeroyd]

I think the problem is with CONFIG_SITE when adCore is built standalone outside of normal areaDetector tree. I've made a few changes to a local fork and the github action now builds - see

master...FreddieAkeroyd:ADCore:master

and

https://github.com/FreddieAkeroyd/ADCore/actions/runs/16063481988

Summary of changes

• added options to CONFIG_SITE rather than CONFIG_SITE.local

I see https://github.com/areaDetector/ADCore/blob/master/.ci-local/adsupport-config.py
run by

ADCore/.ci-local/adsupport.set

Line 6 in 84da957

ADSUPPORT_HOOK=.ci-local/adsupport-config.py

sets a CONFIG_SITE as there is an issue with CONFIG_SITE.local in adsupport, is same true for adCore?

• added HDF5_STATIC_BUILD=NO to CONFIG_SITE

setting to $(STATIC_BUILD) as in e.g.
https://github.com/areaDetector/areaDetector/blob/f4a39a23810a89e29f2fbb45798a105cb1665af3/configure/EXAMPLE_CONFIG_SITE.local.WIN32#L3 didn't work, need to look more

I'll investigate a bit more then create a proper PR