Commit 134f5a3
authored
[BUGFIX] argilla server: Prevent convert
# Description
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->
Changes introduced in #5600
include a but when the fields in the `RecordCreate` schema already
contain `ChatFieldValue` object. This is the cause of [failing
integration tests in the develop
branch](https://github.com/argilla-io/argilla/actions/runs/11380531039/job/31660006108).
The custom validator must skip these objects even if the `pre` flag is
set to True.
This PR fixes the error.
**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->
- Bug fix (non-breaking change which fixes an issue)
**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->
**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->
- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)ChatFieldValue objects (#5605)1 parent 668643c commit 134f5a3
File tree
2 files changed
+27
-1
lines changed- argilla-server
- src/argilla_server/api/schemas/v1
- tests/unit/api/schemas/v1/records
2 files changed
+27
-1
lines changedLines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
111 | 113 | | |
112 | 114 | | |
113 | 115 | | |
| |||
Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
49 | 73 | | |
50 | 74 | | |
51 | 75 | | |
| |||
0 commit comments