Skip to content

Commit 2247283

Browse files
authored
fix: skip helmlint pre-commit hook on CI because helm command is not available (#5654)
# Description This should fix errors raised by our pre-commit actions when trying to run `helm lint` and the `helm` command is not available. I have tried to add `helm` as additional dependency for the `helmlint` hook but is not possible so disabling it by now on CI. It is available when running it locally and you have `helm` installed. **Type of change** - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** - [ ] GitHub Actions with pre-commit should now work as expected without errors. **Checklist** - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
1 parent c060372 commit 2247283

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.pre-commit-config.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,12 @@ repos:
7575
# Helm lint hook
7676
##############################################################################
7777
- repo: https://github.com/gruntwork-io/pre-commit
78-
rev: v0.1.23
78+
rev: v0.1.24
7979
hooks:
8080
- id: helmlint
8181
name: Helm lint
8282
files: '^examples/deployments/k8s/.*\.yaml$'
83-
args: ['helm', 'lint','examples/deployments/k8s/']
83+
args: ["helm", "lint", "examples/deployments/k8s/"]
8484

8585
ci:
8686
autofix_commit_msg: |
@@ -90,5 +90,6 @@ ci:
9090
autoupdate_branch: ""
9191
autoupdate_commit_msg: "[pre-commit.ci] pre-commit autoupdate"
9292
autoupdate_schedule: weekly
93-
skip: []
93+
skip:
94+
- helmlint # Disabling helmlint on CI by now because helm dependency is not available
9495
submodules: false

0 commit comments

Comments
 (0)