Skip to content

Commit 95aac15

Browse files
authored
fix: image field scroll behaviour (#5455)
- Image field text always visible - Scroll only on image - Visible horizontal scroll (webkit)
1 parent a11dc40 commit 95aac15

File tree

2 files changed

+22
-16
lines changed

2 files changed

+22
-16
lines changed

argilla-frontend/components/features/annotation/container/fields/RecordFields.vue

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,5 @@ export default {
7373
min-width: 0;
7474
height: 100%;
7575
min-height: 0;
76-
77-
&__container {
78-
&--image {
79-
overflow-x: auto;
80-
overflow-y: auto;
81-
}
82-
}
8376
}
8477
</style>

argilla-frontend/components/features/annotation/container/fields/image-field/ImageField.vue

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
<template>
22
<div class="image_field" :key="content">
33
<span class="image_field_title" v-text="title" />
4-
<template v-if="!hasError">
4+
<div class="image_field__wrapper" v-if="!hasError">
55
<BaseSpinner v-if="!isLoaded" />
66
<img
77
v-show="isLoaded"
88
:src="content"
99
@error="handleError()"
1010
@load="onLoad()"
1111
/>
12-
</template>
12+
</div>
1313
<div v-else class="image_field_placeholder">
1414
<img src="images/img-placeholder.svg" />
1515
<p v-text="$t('couldNotLoadImage')" />
@@ -57,8 +57,6 @@ export default {
5757
flex-direction: column;
5858
min-height: 100%;
5959
min-width: 100%;
60-
height: fit-content;
61-
width: fit-content;
6260
gap: $base-space * 2;
6361
padding: 2 * $base-space;
6462
background: palette(grey, 800);
@@ -74,16 +72,31 @@ export default {
7472
color: $black-37;
7573
}
7674
77-
img {
78-
max-width: fit-content;
79-
max-height: fit-content;
80-
height: fit-content;
81-
width: fit-content;
75+
&__wrapper {
76+
width: 100%;
77+
height: 100%;
78+
overflow-y: hidden;
79+
overflow-x: scroll;
80+
img {
81+
min-width: fit-content;
82+
min-height: fit-content;
83+
}
8284
}
8385
8486
&_title {
8587
word-break: break-word;
8688
width: calc(100% - 30px);
8789
}
8890
}
91+
::-webkit-scrollbar {
92+
-webkit-appearance: none;
93+
width: 4px;
94+
height: 6px;
95+
}
96+
97+
::-webkit-scrollbar-thumb {
98+
border-radius: $base-space;
99+
background-color: $black-54;
100+
box-shadow: 0 0 1px rgba(255, 255, 255, 0.5);
101+
}
89102
</style>

0 commit comments

Comments
 (0)