Commit d9b215d
refactor: improve get pop issues (#5135)
# Pull Request Template
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->
Closes #5116
CONSIDERATIONS:
- I fixed the planned issues, BUT to order them in descending order, I
had to filter by v2. and the open ones (there were old milestones, and
if the closed ones are shown, only those will be shown). FOR DISTILABEL
UPDATE, the v2 filter should be removed.
I removed an API call as I found a key to determine if a member of the
org/repo opened the issue (pre-commit should not be additionally added
as previously because it only creates PRs, not issues). Locally, with a
token with the permissions defined, it correctly removed the members.
- I realized that the API call to list the issues also retrieves the
pull requests, so I added an if statement to filter them.
- I removed unneeded keys.
<img width="1402" alt="Screenshot 2024-06-30 at 02 42 51"
src="https://github.com/argilla-io/argilla/assets/127759186/5d32ebd9-da3b-4fca-a109-f0c251fe1aa1">
<img width="1402" alt="Screenshot 2024-06-30 at 02 42 38"
src="https://github.com/argilla-io/argilla/assets/127759186/57818ef5-933f-4337-8613-9091e5292fa4">
<img width="1402" alt="Screenshot 2024-06-30 at 02 42 44"
src="https://github.com/argilla-io/argilla/assets/127759186/4dfaee57-bc6c-4d22-b5cb-d51ceeb1827a">
**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->
- Refactor (change restructuring the codebase without changing
functionality)
- Improvement (change adding some improvement to an existing
functionality)
- Documentation update
**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->
**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
---------
Co-authored-by: David Berenstein <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>1 parent 9eda5d1 commit d9b215d
1 file changed
+13
-38
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | 35 | | |
39 | 36 | | |
40 | 37 | | |
41 | 38 | | |
42 | | - | |
43 | 39 | | |
| 40 | + | |
44 | 41 | | |
45 | 42 | | |
46 | 43 | | |
| |||
58 | 55 | | |
59 | 56 | | |
60 | 57 | | |
| 58 | + | |
| 59 | + | |
61 | 60 | | |
62 | 61 | | |
63 | 62 | | |
64 | 63 | | |
65 | 64 | | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | 65 | | |
70 | 66 | | |
71 | 67 | | |
72 | 68 | | |
73 | | - | |
74 | 69 | | |
| 70 | + | |
75 | 71 | | |
76 | 72 | | |
77 | 73 | | |
| |||
80 | 76 | | |
81 | 77 | | |
82 | 78 | | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | 79 | | |
107 | 80 | | |
108 | 81 | | |
109 | 82 | | |
110 | 83 | | |
111 | | - | |
| 84 | + | |
112 | 85 | | |
113 | 86 | | |
114 | 87 | | |
115 | 88 | | |
116 | 89 | | |
117 | | - | |
118 | | - | |
| 90 | + | |
119 | 91 | | |
120 | | - | |
| 92 | + | |
121 | 93 | | |
122 | 94 | | |
123 | 95 | | |
124 | 96 | | |
125 | 97 | | |
126 | | - | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
127 | 102 | | |
128 | | - | |
129 | | - | |
| 103 | + | |
| 104 | + | |
130 | 105 | | |
131 | 106 | | |
132 | 107 | | |
| |||
0 commit comments