From 209711f41ba7ad269cb94bc5b6b3196d778aecbc Mon Sep 17 00:00:00 2001 From: Leire Aguirre Date: Fri, 20 Dec 2024 11:57:44 +0100 Subject: [PATCH 1/6] add mobile platform detection and remove autofocus --- argilla-frontend/assets/scss/base/base.scss | 8 ++++++++ .../container/questions/QuestionsForm.vue | 17 +++++++++++++---- .../v1/infrastructure/services/usePlatform.ts | 4 ++++ 3 files changed, 25 insertions(+), 4 deletions(-) diff --git a/argilla-frontend/assets/scss/base/base.scss b/argilla-frontend/assets/scss/base/base.scss index 383ad3cee4..65abb40b62 100644 --- a/argilla-frontend/assets/scss/base/base.scss +++ b/argilla-frontend/assets/scss/base/base.scss @@ -196,10 +196,18 @@ a { .--heading1 { @include font-size(40px); @include line-height(50px); + @include media(" @@ -29,7 +30,7 @@ @on-click="onDiscard" > @@ -44,7 +45,7 @@ :data-title="!isSaving ? draftSavingTooltip : null" @on-click="onSaveDraft" > - - + @@ -179,7 +184,11 @@ export default { return "--focused-form"; }, formHasFocus() { - return this.autofocusPosition || this.autofocusPosition == 0; + if (!this.$platform.isMobile) { + return this.autofocusPosition || this.autofocusPosition == 0; + } else { + return false; + } }, numberOfQuestions() { return this.record.questions.length; diff --git a/argilla-frontend/v1/infrastructure/services/usePlatform.ts b/argilla-frontend/v1/infrastructure/services/usePlatform.ts index f92a993326..157cc5f1af 100644 --- a/argilla-frontend/v1/infrastructure/services/usePlatform.ts +++ b/argilla-frontend/v1/infrastructure/services/usePlatform.ts @@ -3,5 +3,9 @@ export const usePlatform = () => { return { isMac: userAgent.includes("Mac"), + isMobile: + /Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test( + userAgent + ), }; }; From dcd4afab5908905e256e1fe94b39bef519b850b5 Mon Sep 17 00:00:00 2001 From: Leire Aguirre Date: Fri, 20 Dec 2024 12:00:00 +0100 Subject: [PATCH 2/6] improve annotation page accessibility --- .../base/base-breadcrumbs/BaseBreadcrumbs.vue | 7 +++-- .../base/base-card/BaseCardWithTabs.vue | 30 +++++++++++++++---- .../base/base-search-bar/BaseSearchBar.vue | 1 + .../base/base-switch/BaseSwitch.vue | 26 ++++++++++++---- .../base/base-tooltip/BaseFixedTooltip.vue | 1 + .../fields/image-field/ImageField.vue | 3 +- .../container/fields/sandbox/Sandbox.vue | 1 + .../components/EntityComponent.vue | 1 + .../questions/form/Questions.component.vue | 1 + .../DndSelection.component.vue | 7 ++++- .../rating/RatingMonoSelection.component.vue | 1 + .../LabelSelection.component.vue | 24 ++++++++++++--- .../search-label/SearchLabel.component.vue | 7 ++++- .../single-label/SingleLabel.component.vue | 2 ++ .../span/EntityLabelSelection.component.vue | 5 ++-- .../form/text-area/TextArea.component.vue | 2 ++ .../form/text-area/TextAreaContents.vue | 2 ++ .../header/RadioButtonsSelect.base.vue | 14 +++++++-- .../header/ToggleAnnotationType.vue | 4 +-- .../DatasetSettingsIconFeedbackTask.vue | 2 ++ .../header/header-bar/ExportToHub.vue | 14 +++++++-- .../header/header-bar/HeaderFeedbackTask.vue | 4 +-- .../header/header-bar/ImportData.vue | 3 +- .../search-bar-filter/SearchBarFilter.vue | 11 ++++--- .../annotation/pagination/Pagination.vue | 2 -- .../status-counter/StatusCounterSkeleton.vue | 2 +- .../annotation/settings/SettingsFields.vue | 1 + .../annotation/settings/SettingsMetadata.vue | 1 + .../annotation/settings/SettingsQuestions.vue | 1 + .../TopDatasetSettingsFeedbackTask.vue | 2 +- .../configuration/DatasetConfiguration.vue | 1 + 31 files changed, 141 insertions(+), 42 deletions(-) diff --git a/argilla-frontend/components/base/base-breadcrumbs/BaseBreadcrumbs.vue b/argilla-frontend/components/base/base-breadcrumbs/BaseBreadcrumbs.vue index fa70a8a243..36f3916e86 100644 --- a/argilla-frontend/components/base/base-breadcrumbs/BaseBreadcrumbs.vue +++ b/argilla-frontend/components/base/base-breadcrumbs/BaseBreadcrumbs.vue @@ -16,8 +16,8 @@ -->