include allowed namespaces flag

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>

Author: chetan-rns

agent/filters.go

@@ -29,11 +29,7 @@ func (a *Agent) DefaultAppFilterChain() *filter.Chain[*v1alpha1.Application] {
 
 	// Admit based on namespace of the application
 	fc.AppendAdmitFilter(func(app *v1alpha1.Application) bool {
-		nsList := append([]string{a.namespace}, a.allowedNamespaces...)
-		if a.destinationBasedMapping {
-			nsList = append(nsList, app.Namespace)
-		}
-		if !glob.MatchStringInList(nsList, app.Namespace, glob.REGEXP) {
+		if !glob.MatchStringInList(append([]string{a.namespace}, a.allowedNamespaces...), app.Namespace, glob.REGEXP) {
 			log().Warnf("namespace not allowed: %s", app.QualifiedName())
 			return false
 		}

cmd/argocd-agent/agent.go

@@ -87,6 +87,9 @@ func NewAgentRunCommand() *cobra.Command {
 		// Destination-based mapping options
 		createNamespace         bool
 		destinationBasedMapping bool
+
+		// Allowed namespaces for filtering applications
+		allowedNamespaces []string
 	)
 	command := &cobra.Command{
 		Use:   "agent",
@@ -238,6 +241,7 @@ func NewAgentRunCommand() *cobra.Command {
 			agentOpts = append(agentOpts, agent.WithHeartbeatInterval(heartbeatInterval))
 			agentOpts = append(agentOpts, agent.WithCreateNamespace(createNamespace))
 			agentOpts = append(agentOpts, agent.WithDestinationBasedMapping(destinationBasedMapping))
+			agentOpts = append(agentOpts, agent.WithAllowedNamespaces(allowedNamespaces...))
 
 			if metricsPort > 0 {
 				agentOpts = append(agentOpts, agent.WithMetricsPort(metricsPort))
@@ -362,6 +366,9 @@ func NewAgentRunCommand() *cobra.Command {
 	command.Flags().BoolVar(&createNamespace, "create-namespace",
 		env.BoolWithDefault("ARGOCD_AGENT_CREATE_NAMESPACE", false),
 		"Create target namespace if it doesn't exist when syncing applications (used with destination-based-mapping)")
+	command.Flags().StringSliceVar(&allowedNamespaces, "allowed-namespaces",
+		env.StringSliceWithDefault("ARGOCD_AGENT_ALLOWED_NAMESPACES", nil, []string{}),
+		"List of additional namespaces the agent is allowed to manage applications in")
 
 	command.Flags().StringVar(&kubeConfig, "kubeconfig", "", "Path to a kubeconfig file to use")
 	command.Flags().StringVar(&kubeContext, "kubecontext", "", "Override the default kube context")

hack/dev-env/start-agent-managed.sh

@@ -38,6 +38,7 @@ fi
 
 go run github.com/argoproj-labs/argocd-agent/cmd/argocd-agent agent \
     --agent-mode managed \
+    --allowed-namespaces '*' \
     --creds "mtls:any" \
     --server-address 127.0.0.1 \
     --kubecontext vcluster-agent-managed \