Skip to content

Commit 5cbd95c

Browse files
committed
test: add informer start
Signed-off-by: yeonsoo <[email protected]>
1 parent 894e20a commit 5cbd95c

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

internal/manager/application/application_test.go

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,19 @@ func fakeInformer(t *testing.T, namespace string, objects ...runtime.Object) (*f
5858
informer.WithNamespaceScope[*v1alpha1.Application](namespace),
5959
)
6060
require.NoError(t, err)
61+
62+
go func() {
63+
err = informer.Start(context.Background())
64+
if err != nil {
65+
t.Fatalf("failed to start informer: %v", err)
66+
}
67+
}()
68+
69+
// cache.WaitForCacheSync(context.Background().Done(), informer.HasSynced)
70+
if err = informer.WaitForSync(context.Background()); err != nil {
71+
t.Fatalf("failed to wait for informer sync: %v", err)
72+
}
73+
6174
return appC, informer
6275
}
6376

@@ -69,6 +82,7 @@ func fakeAppManager(t *testing.T, objects ...runtime.Object) (*fakeappclient.Cli
6982
am, err := NewApplicationManager(be, "argocd")
7083
assert.NoError(t, err)
7184

85+
// go am.StartBackend(context.Background())
7286
return appC, am
7387
}
7488

@@ -209,7 +223,13 @@ func Test_ManagerUpdateManaged(t *testing.T) {
209223
mgr, err := NewApplicationManager(be, "argocd", WithMode(manager.ManagerModeManaged), WithRole(manager.ManagerRoleAgent))
210224
require.NoError(t, err)
211225

226+
// ctx, cancel := context.WithCancel(context.Background())
227+
// defer cancel()
228+
// go mgr.StartBackend(ctx)
229+
// cache.WaitForCacheSync(ctx.Done(), ai.HasSynced)
230+
212231
updated, err := mgr.UpdateManagedApp(context.Background(), incoming)
232+
213233
require.NoError(t, err)
214234
require.NotNil(t, updated)
215235

principal/event_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ func Test_CreateEvents(t *testing.T) {
128128
wq.On("Get").Return(&ev, false)
129129
wq.On("Done", &ev)
130130
s, err := NewServer(context.Background(), fac, "argocd", WithGeneratedTokenSigningKey(), WithAutoNamespaceCreate(true, "", nil))
131+
s.Start(context.Background(), make(chan error))
131132
s.clusterMgr.MapCluster("argocd", &v1alpha1.Cluster{Name: "argocd", Server: "https://argocd.com"})
132133
require.NoError(t, err)
133134
s.setAgentMode("argocd", types.AgentModeAutonomous)
@@ -247,6 +248,7 @@ func Test_CreateEvents(t *testing.T) {
247248
wq.On("Get").Return(&ev, false)
248249
wq.On("Done", &ev)
249250
s, err := NewServer(context.Background(), fac, "argocd", WithGeneratedTokenSigningKey())
251+
s.Start(context.Background(), make(chan error))
250252
require.NoError(t, err)
251253
s.clusterMgr.MapCluster("foo", &v1alpha1.Cluster{Name: "foo", Server: "https://foo.com"})
252254
s.setAgentMode("foo", types.AgentModeAutonomous)
@@ -327,6 +329,7 @@ func Test_UpdateEvents(t *testing.T) {
327329
wq.On("Done", &ev)
328330
s, err := NewServer(context.Background(), fac, "argocd", WithGeneratedTokenSigningKey())
329331
require.NoError(t, err)
332+
s.Start(context.Background(), make(chan error))
330333
s.setAgentMode("foo", types.AgentModeAutonomous)
331334
s.clusterMgr.MapCluster("foo", &v1alpha1.Cluster{Name: "foo", Server: "https://foo.com"})
332335
got, err := s.processRecvQueue(context.Background(), "foo", wq)
@@ -446,6 +449,7 @@ func Test_DeleteEvents_ManagedMode(t *testing.T) {
446449
wq.On("Done", &ev)
447450
s, err := NewServer(context.Background(), fac, "argocd", WithGeneratedTokenSigningKey())
448451
require.NoError(t, err)
452+
449453
s.setAgentMode("foo", types.AgentModeManaged)
450454

451455
_, err = fac.ApplicationsClientset.ArgoprojV1alpha1().Applications(delApp.Namespace).Create(context.Background(), delApp, v1.CreateOptions{})

0 commit comments

Comments
 (0)