fix: revert non-source updates to AppProjects and Repositories #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
- Coverage 45.86% 45.50% -0.36%
==========================================
Files 90 90
Lines 12066 12314 +248
==========================================
+ Hits 5534 5604 +70
- Misses 6085 6251 +166
- Partials 447 459 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chetan-rns
force-pushed
the
revert-appproject-changes
branch
2 times, most recently
from
0059af7 to
00feb32
Compare
Signed-off-by: Chetan Banavikalmutt <[email protected]>
Signed-off-by: Chetan Banavikalmutt <[email protected]> Assisted-by: Cursor
Signed-off-by: Chetan Banavikalmutt <[email protected]>
Signed-off-by: Chetan Banavikalmutt <[email protected]> Assisted-by: Cursor
Signed-off-by: Chetan Banavikalmutt <[email protected]>
chetan-rns
force-pushed
the
revert-appproject-changes
branch
from
00feb32 to
7a1fbcf
Compare
Signed-off-by: Chetan Banavikalmutt <[email protected]>
chetan-rns
force-pushed
the
revert-appproject-changes
branch
from
7a1fbcf to
0f1b8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it:
This PR extends #400
All updates to the AppProject and the Repository must come from the source, i.e, the principal in managed mode and the agent in autonomous mode. Any changes made by the user on the non-source cluster must be reverted to keep the resources in sync with the source cluster. In this PR:
Which issue(s) this PR fixes:
Fixes #546
How to test changes / Special notes to the reviewer:
Checklist