Bump-dependencies (#678)

* chore: upgraded gitlab.com/gitlab-org/api/client-go v0.121.0 => v0.143.3
* chore: upgraded code.gitea.io/sdk/gitea v0.19.0 => v0.22.0
* chore: upgraded github.com/redis/go-redis/v9 v9.6.1 => v9.14.0
* chore: upgraded github.com/go-jose/go-jose/v4 v4.0.4 => v4.1.2
* chore: upgraded github.com/briandowns/spinner v1.23.1 => v1.23.2
* chore: upgraded github.com/spf13/pflag v1.0.5 => v1.0.10
* chore: upgraded github.com/argoproj/argo-cd/v2 v2.13.4 => github.com/argoproj/argo-cd/v3 v3.1.5
* update to golang 1.25.1
* chore: updated golangci-lint to 2.4.0

---------

Signed-off-by: Noam Gal <[email protected]>

Author: ATGardner

.golangci.yaml

@@ -1,33 +1,32 @@
-# This file contains all available configuration options
-# with their default values.
-
-# options for analysis running
+version: "2"
 run:
-  # default concurrency is a available CPU number
   concurrency: 4
-
-  # timeout for analysis, e.g. 30s, 5m, default is 1m
-  timeout: 5m
-
-  # exit code when at least one issue was found, default is 1
   issues-exit-code: 1
-
 linters:
   enable:
     - gocyclo
-    - errcheck
     - godox
-# all available settings of specific linters
-linters-settings:
-  errcheck:
-    # report about not checking of errors in type assertions: `a := b.(MyStruct)`;
-    # default is false: such cases aren't reported by default.
-    check-type-assertions: false
-
-    # report about assignment of errors to blank identifier: `num, _ := strconv.Atoi(numStr)`;
-    # default is false: such cases aren't reported by default.
-    check-blank: false
-
-  gocyclo:
-    # minimal code complexity to report, 30 by default (but we recommend 10-20)
-    min-complexity: 18
+  settings:
+    errcheck:
+      check-type-assertions: false
+      check-blank: false
+    gocyclo:
+      min-complexity: 18
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Dockerfile

@@ -25,7 +25,7 @@ USER 999
 WORKDIR /home/autopilot
 
 ### Build
-FROM docker.io/library/golang:1.24 AS build
+FROM docker.io/library/golang:1.25 AS build
 
 WORKDIR /go/src/github.com/argoproj-labs/argocd-autopilot
 

Makefile

@@ -170,12 +170,12 @@ MOCKGEN = ${LOCALBIN}/mockgen
 
 ## Tool Versions
 MOCKGEN_VERSION ?= v1.6.0
-GOLANGCI_LINT_VERSION ?= v1.64.7
+GOLANGCI_LINT_VERSION ?= v2.4.0
 
 .PHONY: golangci-lint
 golangci-lint: $(GOLANGCI_LINT) ## Download golangci-lint locally if necessary.
 $(GOLANGCI_LINT):
-	$(call go-install-tool,$(GOLANGCI_LINT),github.com/golangci/golangci-lint/cmd/golangci-lint,$(GOLANGCI_LINT_VERSION))
+	$(call go-install-tool,$(GOLANGCI_LINT),github.com/golangci/golangci-lint/v2/cmd/golangci-lint,$(GOLANGCI_LINT_VERSION))
 
 .PHONY: mockgen
 mockgen: $(MOCKGEN) ## Download mockgen locally if necessary.

build/ci.yml

@@ -19,7 +19,7 @@ steps:
   prepare_env_vars: &deps
     stage: Prepare
     title: prepare-env
-    image: quay.io/codefresh/golang-ci-helper:1.24.1
+    image: quay.io/codefresh/golang-ci-helper:1.25
     commands:
       - cf_export GO111MODULE=on
       - cf_export GOCACHE=/codefresh/volume/gocache # change gopath to codefresh shared volume

build/release.yml

@@ -20,7 +20,7 @@ steps:
   check_version: &deps
     stage: Prepare
     title: check version
-    image: quay.io/codefresh/golang-ci-helper:1.24.1
+    image: quay.io/codefresh/golang-ci-helper:1.25
     commands:
     - cf_export GO111MODULE=on
     - cf_export GOCACHE=/codefresh/volume/gocache # change gopath to codefresh shared volume

build/sanity.yml

@@ -18,7 +18,7 @@ steps:
   prep: &deps
     stage: "prepare"
     title: "prepare env vars"
-    image: quay.io/codefresh/golang-ci-helper:1.24.1
+    image: quay.io/codefresh/golang-ci-helper:1.25
     commands:
     - cf_export GO111MODULE=on
     - cf_export NAMESPACE=${{KUBE_NAMESPACE}}-$(date "+%M-%S")

cmd/commands/app.go

@@ -17,7 +17,7 @@ import (
 	"github.com/argoproj-labs/argocd-autopilot/pkg/store"
 	"github.com/argoproj-labs/argocd-autopilot/pkg/util"
 
-	argocdv1alpha1 "github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
+	argocdv1alpha1 "github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1"
 	"github.com/go-git/go-billy/v5/memfs"
 	"github.com/go-git/go-billy/v5/osfs"
 	billyUtils "github.com/go-git/go-billy/v5/util"
@@ -264,7 +264,7 @@ var setAppOptsDefaults = func(ctx context.Context, repofs fs.FS, opts *AppCreate
 	if opts.AppOpts.Labels == nil {
 		opts.AppOpts.Labels = opts.Labels
 	}
-	
+
 	if opts.AppOpts.Annotations == nil {
 		opts.AppOpts.Annotations = opts.Annotations
 	}
@@ -282,10 +282,10 @@ var setAppOptsDefaults = func(ctx context.Context, repofs fs.FS, opts *AppCreate
 		url := host + orgRepo + suffix
 		log.G(ctx).Infof("cloning repo: '%s', to infer app type from path '%s'", url, p)
 		cloneOpts := &git.CloneOptions{
-			Repo: opts.AppOpts.AppSpecifier,
-			Auth: opts.CloneOpts.Auth,
+			Repo:     opts.AppOpts.AppSpecifier,
+			Auth:     opts.CloneOpts.Auth,
 			Provider: opts.CloneOpts.Provider,
-			FS:   fs.Create(memfs.New()),
+			FS:       fs.Create(memfs.New()),
 		}
 		cloneOpts.Parse()
 		_, fsys, err = getRepo(ctx, cloneOpts)

cmd/commands/app_test.go

@@ -18,7 +18,7 @@ import (
 	kubemocks "github.com/argoproj-labs/argocd-autopilot/pkg/kube/mocks"
 	"github.com/argoproj-labs/argocd-autopilot/pkg/store"
 
-	argocdv1alpha1 "github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
+	argocdv1alpha1 "github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1"
 	"github.com/go-git/go-billy/v5/memfs"
 	billyUtils "github.com/go-git/go-billy/v5/util"
 	"github.com/golang/mock/gomock"

cmd/commands/common.go

@@ -16,7 +16,7 @@ import (
 	"github.com/argoproj-labs/argocd-autopilot/pkg/store"
 	"github.com/argoproj-labs/argocd-autopilot/pkg/util"
 
-	argocdv1alpha1 "github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
+	argocdv1alpha1 "github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"sigs.k8s.io/yaml"
 )
@@ -139,11 +139,11 @@ func createApp(opts *createAppOptions) ([]byte, error) {
 		},
 	}
 	if opts.noFinalizer {
-		app.ObjectMeta.Finalizers = []string{}
+		app.Finalizers = []string{}
 	}
 	if len(opts.labels) > 0 {
 		for k, v := range opts.labels {
-			app.ObjectMeta.Labels[k] = v
+			app.Labels[k] = v
 		}
 	}
 

cmd/commands/project.go

@@ -19,7 +19,7 @@ import (
 	"github.com/argoproj-labs/argocd-autopilot/pkg/store"
 	"github.com/argoproj-labs/argocd-autopilot/pkg/util"
 
-	argocdv1alpha1 "github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
+	argocdv1alpha1 "github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1"
 	"github.com/go-git/go-billy/v5/memfs"
 	billyUtils "github.com/go-git/go-billy/v5/util"
 	"github.com/spf13/cobra"