fix: Only fetch metadata when it is required by update-strategy (#32)

* fix: Only fetch metadata when it is required by update-strategy

* Update CHANGELOG

Author: jannfis

CHANGELOG.md

@@ -8,6 +8,18 @@ handling on your side.
 
 ### Upgrade notes (no really, you MUST read this)
 
+### Bug fixes
+
+* fix: Only fetch metadata when require by update strategy
+
+### New features
+
+### Other changes
+
+## 2020-08-10 - Release v0.3.0
+
+### Upgrade notes (no really, you MUST read this)
+
 * Syntax change for running: `argocd-image-updater run [flags]` instead of `argocd-image-updater [flags]` has now to be used
 * **Attention:** Helm annotation names have changed from `<image_alias>.image-{name,tag,spec}` to `<image_alias>.helm.image-{name,tag,spec}`
 * Specifying target image name for Kustomize applications now require their own annotation, the image alias is not re-used for this anymore

cmd/main.go

@@ -90,16 +90,6 @@ func updateApplication(argoClient *argocd.ArgoCD, kubeClient *client.KubernetesC
 			continue
 		}
 
-		// Get list of available image tags from the repository
-		tags, err := rep.GetTags(applicationImage, kubeClient)
-		if err != nil {
-			imgCtx.Errorf("Could not get tags from registry: %v", err)
-			result.NumErrors += 1
-			continue
-		}
-
-		imgCtx.Tracef("List of available tags found: %v", tags.Tags())
-
 		var vc image.VersionConstraint
 		if updateableImage.ImageTag != nil {
 			vc.Constraint = updateableImage.ImageTag.TagName
@@ -110,6 +100,16 @@ func updateApplication(argoClient *argocd.ArgoCD, kubeClient *client.KubernetesC
 
 		vc.SortMode = updateableImage.GetParameterUpdateStrategy(curApplication.Application.Annotations)
 
+		// Get list of available image tags from the repository
+		tags, err := rep.GetTags(applicationImage, kubeClient, &vc)
+		if err != nil {
+			imgCtx.Errorf("Could not get tags from registry: %v", err)
+			result.NumErrors += 1
+			continue
+		}
+
+		imgCtx.Tracef("List of available tags found: %v", tags.Tags())
+
 		// Get the latest available tag matching any constraint that might be set
 		// for allowed updates.
 		latest, err := applicationImage.GetNewestVersionFromTags(&vc, tags)

pkg/registry/registry.go

@@ -20,7 +20,7 @@ import (
 )
 
 // GetTags returns a list of available tags for the given image
-func (clientInfo *RegistryEndpoint) GetTags(img *image.ContainerImage, kubeClient *client.KubernetesClient) (*tag.ImageTagList, error) {
+func (clientInfo *RegistryEndpoint) GetTags(img *image.ContainerImage, kubeClient *client.KubernetesClient, vc *image.VersionConstraint) (*tag.ImageTagList, error) {
 	var tagList *tag.ImageTagList = tag.NewImageTagList()
 	var imgTag *tag.ImageTag
 	var err error
@@ -51,6 +51,16 @@ func (clientInfo *RegistryEndpoint) GetTags(img *image.ContainerImage, kubeClien
 		return nil, err
 	}
 
+	// If we don't want to fetch meta data, just build the taglist and return it
+	// with dummy meta data.
+	if vc.SortMode != image.VersionSortLatest {
+		for _, tagStr := range tags {
+			imgTag = tag.NewImageTag(tagStr, time.Unix(0, 0))
+			tagList.Add(imgTag)
+		}
+		return tagList, nil
+	}
+
 	// Fetch the manifest for the tag -- we need v1, because it contains history
 	// information that we require.
 	for _, tagStr := range tags {