chore: adding test coverage for NewClientMetrics & NewEndpointMetrics (#743)

* adding test coverage for NewClientMetrics & NewEndpointMetrics

Signed-off-by: zhaque44 <[email protected]>

* chore: forgot to run go tidy

Signed-off-by: zhaque44 <[email protected]>

---------

Signed-off-by: zhaque44 <[email protected]>

Author: Zubair Haque

pkg/metrics/metrics_test.go

@@ -0,0 +1,42 @@
+package metrics
+
+import (
+	"testing"
+
+	"github.com/prometheus/client_golang/prometheus"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestMetricsInitialization(t *testing.T) {
+	t.Run("NewEndpointMetrics", func(t *testing.T) {
+		prometheus.DefaultRegisterer = prometheus.NewRegistry()
+		epm := NewEndpointMetrics()
+		assert.NotNil(t, epm)
+		assert.NotNil(t, epm.requestsTotal)
+		assert.NotNil(t, epm.requestsFailed)
+
+		prometheus.DefaultRegisterer = nil
+		epm = NewEndpointMetrics()
+		assert.NotNil(t, epm)
+		assert.NotNil(t, epm.requestsTotal)
+		assert.NotNil(t, epm.requestsFailed)
+	})
+
+	t.Run("NewClientMetrics", func(t *testing.T) {
+		prometheus.DefaultRegisterer = prometheus.NewRegistry()
+		cpm := NewClientMetrics()
+		assert.NotNil(t, cpm)
+		assert.NotNil(t, cpm.argoCDRequestsTotal)
+		assert.NotNil(t, cpm.argoCDRequestsErrorsTotal)
+		assert.NotNil(t, cpm.kubeAPIRequestsTotal)
+		assert.NotNil(t, cpm.kubeAPIRequestsErrorsTotal)
+
+		prometheus.DefaultRegisterer = nil
+		cpm = NewClientMetrics()
+		assert.NotNil(t, cpm)
+		assert.NotNil(t, cpm.argoCDRequestsTotal)
+		assert.NotNil(t, cpm.argoCDRequestsErrorsTotal)
+		assert.NotNil(t, cpm.kubeAPIRequestsTotal)
+		assert.NotNil(t, cpm.kubeAPIRequestsErrorsTotal)
+	})
+}