Skip to content

Commit f9dff8d

Browse files
authored
chore: Make release script multi-arch aware (#401)
Signed-off-by: jannfis <[email protected]>
1 parent 48e0bf2 commit f9dff8d

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

Makefile

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,16 @@ multiarch-image:
8989
--platform ${RELEASE_IMAGE_PLATFORMS} ${DOCKERX_PUSH} \
9090
.
9191

92+
.PHONY: multiarch-image
93+
multiarch-image-push:
94+
docker buildx build \
95+
-t ${IMAGE_PREFIX}${IMAGE_NAME}:${IMAGE_TAG} \
96+
--progress plain \
97+
--pull \
98+
--push \
99+
--platform ${RELEASE_IMAGE_PLATFORMS} ${DOCKERX_PUSH} \
100+
.
101+
92102
.PHONY: image-push
93103
image-push: image
94104
docker push ${IMAGE_PREFIX}${IMAGE_NAME}:${IMAGE_TAG}

hack/release.sh

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,18 @@ echo "*** performing release commit"
5050
git commit -S -s -m "Release ${TARGET_TAG}" VERSION manifests/
5151
git tag ${TARGET_TAG}
5252

53-
echo "*** build docker image"
54-
make image
53+
echo "*** build multiarch docker image"
54+
make multiarch-image
55+
56+
echo "*** build multiarch release binaries"
57+
make release-images
5558

5659
echo
5760
echo "*** done"
5861
echo
5962
echo "If everything is fine, push changes to GitHub and Docker Hub:"
6063
echo
6164
echo " git push ${TARGET_REMOTE} $RELEASE_BRANCH ${TARGET_TAG}"
62-
echo " make IMAGE_TAG='${TARGET_TAG}' image-push"
65+
echo " make IMAGE_TAG='${TARGET_TAG}' multiarch-image-push"
6366
echo
64-
echo "Then, create release tag and execute upload-release-assets.sh"
67+
echo "Then, create release tag and execute upload-multiarch-release-assets.sh"

0 commit comments

Comments
 (0)