-
Notifications
You must be signed in to change notification settings - Fork 316
doc(installation): add multi-cluster setup section #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: dkarpele <[email protected]>
WalkthroughUpdates the installation documentation to clarify multi-cluster environment requirements and add a disclaimer about Kubernetes installation. Specifies that the Image Updater controller and ImageUpdater CRs must reside on the Argo CD management cluster and cannot discover CRs from other clusters. Changes
Pre-merge checks✅ Passed checks (3 passed)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/install/installation.md (2)
9-18: Clear and accurate multi-cluster constraint documentation.The new section effectively clarifies the architectural requirement that both the Image Updater controller and ImageUpdater CRs must reside on the management cluster. The use of concrete cluster naming (A/B) and the summary statement are helpful.
Optional enhancement: Consider adding a brief clarification for users who need to manage images across multiple clusters—e.g., whether they would need to run separate Image Updater instances in each cluster. This would help set expectations for more complex topologies.
22-23: Minor tone refinement for documentation consistency.The reassurance is helpful, but the informal tone ("Don't worry") is inconsistent with the rest of the documentation. Consider rephrasing for a more neutral tone while retaining the reassuring message.
Example:
-Don't worry, without creating any ImageUpdater custom resources, it will not start modifying your workloads yet. +Without creating any ImageUpdater custom resources, the controller will remain inactive and will not modify your workloads.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/install/installation.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Analyze (go)
- GitHub Check: Ensure code is correctly linted
- GitHub Check: Ensure registry-scanner Go modules synchronicity and run tests
- GitHub Check: Ensure unit tests are passing
- GitHub Check: build_image
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1363 +/- ##
=======================================
Coverage 70.80% 70.80%
=======================================
Files 49 49
Lines 4528 4528
=======================================
Hits 3206 3206
Misses 1125 1125
Partials 197 197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
See discussion #1350
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.