Skip to content

Conversation

@dkarpele
Copy link
Collaborator

@dkarpele dkarpele commented Nov 20, 2025

See discussion #1350

Summary by CodeRabbit

  • Documentation
    • Added guidance on Image Updater controller placement in multi-cluster environments, clarifying that the controller and ImageUpdater resources must be deployed to the Argo CD management cluster.
    • Added clarification that ImageUpdater resources must be created for the Image Updater to begin modifying workloads.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2025

Walkthrough

Updates the installation documentation to clarify multi-cluster environment requirements and add a disclaimer about Kubernetes installation. Specifies that the Image Updater controller and ImageUpdater CRs must reside on the Argo CD management cluster and cannot discover CRs from other clusters.

Changes

Cohort / File(s) Summary
Installation Documentation
docs/install/installation.md
Adds "Multi-Cluster Environments" section clarifying controller and CR placement on management cluster; adds disclaimer that Image Updater requires ImageUpdater CRs to modify workloads when deployed as a Kubernetes workload.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a multi-cluster setup section to the installation documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
docs/install/installation.md (2)

9-18: Clear and accurate multi-cluster constraint documentation.

The new section effectively clarifies the architectural requirement that both the Image Updater controller and ImageUpdater CRs must reside on the management cluster. The use of concrete cluster naming (A/B) and the summary statement are helpful.

Optional enhancement: Consider adding a brief clarification for users who need to manage images across multiple clusters—e.g., whether they would need to run separate Image Updater instances in each cluster. This would help set expectations for more complex topologies.


22-23: Minor tone refinement for documentation consistency.

The reassurance is helpful, but the informal tone ("Don't worry") is inconsistent with the rest of the documentation. Consider rephrasing for a more neutral tone while retaining the reassuring message.

Example:

-Don't worry, without creating any ImageUpdater custom resources, it will not start modifying your workloads yet.
+Without creating any ImageUpdater custom resources, the controller will remain inactive and will not modify your workloads.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73263e7 and c78b15c.

📒 Files selected for processing (1)
  • docs/install/installation.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Analyze (go)
  • GitHub Check: Ensure code is correctly linted
  • GitHub Check: Ensure registry-scanner Go modules synchronicity and run tests
  • GitHub Check: Ensure unit tests are passing
  • GitHub Check: build_image

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.80%. Comparing base (73263e7) to head (c78b15c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1363   +/-   ##
=======================================
  Coverage   70.80%   70.80%           
=======================================
  Files          49       49           
  Lines        4528     4528           
=======================================
  Hits         3206     3206           
  Misses       1125     1125           
  Partials      197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants