Fix syntax error in Teams notifications (#271)

MrSaints · web-flow · commit 567fe2a87f86 · 2021-05-02T00:48:54.000+09:00
There was a trailing comma at the end of the condition fact value
which made the JSON syntactically invalid causing notifications
to not be handled / published.
diff --git a/catalog/install.yaml b/catalog/install.yaml
@@ -69,7 +69,7 @@ data:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
@@ -141,7 +141,7 @@ data:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
@@ -217,7 +217,7 @@ data:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
@@ -293,7 +293,7 @@ data:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
@@ -369,7 +369,7 @@ data:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
@@ -444,7 +444,7 @@ data:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
diff --git a/catalog/templates/app-deployed.yaml b/catalog/templates/app-deployed.yaml
@@ -56,7 +56,7 @@ teams:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
diff --git a/catalog/templates/app-health-degraded.yaml b/catalog/templates/app-health-degraded.yaml
@@ -48,7 +48,7 @@ teams:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
diff --git a/catalog/templates/app-sync-failed.yaml b/catalog/templates/app-sync-failed.yaml
@@ -52,7 +52,7 @@ teams:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
diff --git a/catalog/templates/app-sync-running.yaml b/catalog/templates/app-sync-running.yaml
@@ -51,7 +51,7 @@ teams:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
diff --git a/catalog/templates/app-sync-status-unknown.yaml b/catalog/templates/app-sync-status-unknown.yaml
@@ -52,7 +52,7 @@ teams:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
diff --git a/catalog/templates/app-sync-succeeded.yaml b/catalog/templates/app-sync-succeeded.yaml
@@ -52,7 +52,7 @@ teams:
           {{if $index}},{{end}}
           {
             "name": "{{$c.type}}",
-            "value": "{{$c.message}}",
+            "value": "{{$c.message}}"
           }
         {{end}}
         ]
diff --git a/docs/catalog.md b/docs/catalog.md
@@ -91,7 +91,7 @@ teams:
       {{if $index}},{{end}}
       {
         "name": "{{$c.type}}",
-        "value": "{{$c.message}}",
+        "value": "{{$c.message}}"
       }
     {{end}}
     ]
@@ -167,7 +167,7 @@ teams:
       {{if $index}},{{end}}
       {
         "name": "{{$c.type}}",
-        "value": "{{$c.message}}",
+        "value": "{{$c.message}}"
       }
     {{end}}
     ]
@@ -247,7 +247,7 @@ teams:
       {{if $index}},{{end}}
       {
         "name": "{{$c.type}}",
-        "value": "{{$c.message}}",
+        "value": "{{$c.message}}"
       }
     {{end}}
     ]
@@ -327,7 +327,7 @@ teams:
       {{if $index}},{{end}}
       {
         "name": "{{$c.type}}",
-        "value": "{{$c.message}}",
+        "value": "{{$c.message}}"
       }
     {{end}}
     ]
@@ -407,7 +407,7 @@ teams:
       {{if $index}},{{end}}
       {
         "name": "{{$c.type}}",
-        "value": "{{$c.message}}",
+        "value": "{{$c.message}}"
       }
     {{end}}
     ]
@@ -486,7 +486,7 @@ teams:
       {{if $index}},{{end}}
       {
         "name": "{{$c.type}}",
-        "value": "{{$c.message}}",
+        "value": "{{$c.message}}"
       }
     {{end}}
     ]

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ data:`
`69`	`69`	`{{if $index}},{{end}}`
`70`	`70`	`{`
`71`	`71`	`"name": "{{$c.type}}",`
`72`		`- "value": "{{$c.message}}",`
	`72`	`+ "value": "{{$c.message}}"`
`73`	`73`	`}`
`74`	`74`	`{{end}}`
`75`	`75`	`]`
`@@ -141,7 +141,7 @@ data:`
`141`	`141`	`{{if $index}},{{end}}`
`142`	`142`	`{`
`143`	`143`	`"name": "{{$c.type}}",`
`144`		`- "value": "{{$c.message}}",`
	`144`	`+ "value": "{{$c.message}}"`
`145`	`145`	`}`
`146`	`146`	`{{end}}`
`147`	`147`	`]`
`@@ -217,7 +217,7 @@ data:`
`217`	`217`	`{{if $index}},{{end}}`
`218`	`218`	`{`
`219`	`219`	`"name": "{{$c.type}}",`
`220`		`- "value": "{{$c.message}}",`
	`220`	`+ "value": "{{$c.message}}"`
`221`	`221`	`}`
`222`	`222`	`{{end}}`
`223`	`223`	`]`
`@@ -293,7 +293,7 @@ data:`
`293`	`293`	`{{if $index}},{{end}}`
`294`	`294`	`{`
`295`	`295`	`"name": "{{$c.type}}",`
`296`		`- "value": "{{$c.message}}",`
	`296`	`+ "value": "{{$c.message}}"`
`297`	`297`	`}`
`298`	`298`	`{{end}}`
`299`	`299`	`]`
`@@ -369,7 +369,7 @@ data:`
`369`	`369`	`{{if $index}},{{end}}`
`370`	`370`	`{`
`371`	`371`	`"name": "{{$c.type}}",`
`372`		`- "value": "{{$c.message}}",`
	`372`	`+ "value": "{{$c.message}}"`
`373`	`373`	`}`
`374`	`374`	`{{end}}`
`375`	`375`	`]`
`@@ -444,7 +444,7 @@ data:`
`444`	`444`	`{{if $index}},{{end}}`
`445`	`445`	`{`
`446`	`446`	`"name": "{{$c.type}}",`
`447`		`- "value": "{{$c.message}}",`
	`447`	`+ "value": "{{$c.message}}"`
`448`	`448`	`}`
`449`	`449`	`{{end}}`
`450`	`450`	`]`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ teams:`
`56`	`56`	`{{if $index}},{{end}}`
`57`	`57`	`{`
`58`	`58`	`"name": "{{$c.type}}",`
`59`		`- "value": "{{$c.message}}",`
	`59`	`+ "value": "{{$c.message}}"`
`60`	`60`	`}`
`61`	`61`	`{{end}}`
`62`	`62`	`]`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ teams:`
`48`	`48`	`{{if $index}},{{end}}`
`49`	`49`	`{`
`50`	`50`	`"name": "{{$c.type}}",`
`51`		`- "value": "{{$c.message}}",`
	`51`	`+ "value": "{{$c.message}}"`
`52`	`52`	`}`
`53`	`53`	`{{end}}`
`54`	`54`	`]`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ teams:`
`52`	`52`	`{{if $index}},{{end}}`
`53`	`53`	`{`
`54`	`54`	`"name": "{{$c.type}}",`
`55`		`- "value": "{{$c.message}}",`
	`55`	`+ "value": "{{$c.message}}"`
`56`	`56`	`}`
`57`	`57`	`{{end}}`
`58`	`58`	`]`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ teams:`
`51`	`51`	`{{if $index}},{{end}}`
`52`	`52`	`{`
`53`	`53`	`"name": "{{$c.type}}",`
`54`		`- "value": "{{$c.message}}",`
	`54`	`+ "value": "{{$c.message}}"`
`55`	`55`	`}`
`56`	`56`	`{{end}}`
`57`	`57`	`]`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ teams:`
`91`	`91`	`{{if $index}},{{end}}`
`92`	`92`	`{`
`93`	`93`	`"name": "{{$c.type}}",`
`94`		`- "value": "{{$c.message}}",`
	`94`	`+ "value": "{{$c.message}}"`
`95`	`95`	`}`
`96`	`96`	`{{end}}`
`97`	`97`	`]`
`@@ -167,7 +167,7 @@ teams:`
`167`	`167`	`{{if $index}},{{end}}`
`168`	`168`	`{`
`169`	`169`	`"name": "{{$c.type}}",`
`170`		`- "value": "{{$c.message}}",`
	`170`	`+ "value": "{{$c.message}}"`
`171`	`171`	`}`
`172`	`172`	`{{end}}`
`173`	`173`	`]`
`@@ -247,7 +247,7 @@ teams:`
`247`	`247`	`{{if $index}},{{end}}`
`248`	`248`	`{`
`249`	`249`	`"name": "{{$c.type}}",`
`250`		`- "value": "{{$c.message}}",`
	`250`	`+ "value": "{{$c.message}}"`
`251`	`251`	`}`
`252`	`252`	`{{end}}`
`253`	`253`	`]`
`@@ -327,7 +327,7 @@ teams:`
`327`	`327`	`{{if $index}},{{end}}`
`328`	`328`	`{`
`329`	`329`	`"name": "{{$c.type}}",`
`330`		`- "value": "{{$c.message}}",`
	`330`	`+ "value": "{{$c.message}}"`
`331`	`331`	`}`
`332`	`332`	`{{end}}`
`333`	`333`	`]`
`@@ -407,7 +407,7 @@ teams:`
`407`	`407`	`{{if $index}},{{end}}`
`408`	`408`	`{`
`409`	`409`	`"name": "{{$c.type}}",`
`410`		`- "value": "{{$c.message}}",`
	`410`	`+ "value": "{{$c.message}}"`
`411`	`411`	`}`
`412`	`412`	`{{end}}`
`413`	`413`	`]`
`@@ -486,7 +486,7 @@ teams:`
`486`	`486`	`{{if $index}},{{end}}`
`487`	`487`	`{`
`488`	`488`	`"name": "{{$c.type}}",`
`489`		`- "value": "{{$c.message}}",`
	`489`	`+ "value": "{{$c.message}}"`
`490`	`490`	`}`
`491`	`491`	`{{end}}`
`492`	`492`	`]`