Skip to content
This repository was archived by the owner on Oct 19, 2024. It is now read-only.

Commit a6d446b

Browse files
author
Alexander Matyushentsev
authored
fix: fix nil pointer dereferece in repo.GetAppDetails function (#267)
Signed-off-by: Alexander Matyushentsev <[email protected]>
1 parent 5092d75 commit a6d446b

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

shared/argocd/service.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,15 @@ func (svc *argoCDService) GetAppDetails(ctx context.Context, appSource *v1alpha1
9898
if err != nil {
9999
return nil, err
100100
}
101-
has := &shared.HelmAppSpec{
102-
Name: appDetail.Helm.Name,
103-
ValueFiles: appDetail.Helm.ValueFiles,
104-
Parameters: appDetail.Helm.Parameters,
105-
Values: appDetail.Helm.Values,
106-
FileParameters: appDetail.Helm.FileParameters,
101+
var has *shared.HelmAppSpec
102+
if appDetail.Helm != nil {
103+
has = &shared.HelmAppSpec{
104+
Name: appDetail.Helm.Name,
105+
ValueFiles: appDetail.Helm.ValueFiles,
106+
Parameters: appDetail.Helm.Parameters,
107+
Values: appDetail.Helm.Values,
108+
FileParameters: appDetail.Helm.FileParameters,
109+
}
107110
}
108111
return &shared.AppDetail{
109112
Type: appDetail.Type,

0 commit comments

Comments
 (0)