chore!: add ExactlyOneOf validation for SCM provider fields (#586)

* chore!: add ExactlyOneOf validation for SCM provider fields

Signed-off-by: Michael Crenshaw <[email protected]>

* fix tests

Signed-off-by: Michael Crenshaw <[email protected]>

* simplify

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>

Author: crenshaw-dev

api/v1alpha1/gitrepository_types.go

@@ -24,6 +24,7 @@ import (
 // NOTE: json tags are required.  Any new fields you add must have json tags for the fields to be serialized.
 
 // GitRepositorySpec defines the desired state of GitRepository
+// +kubebuilder:validation:ExactlyOneOf=github;gitlab;forgejo;fake
 type GitRepositorySpec struct {
 	GitHub  *GitHubRepo  `json:"github,omitempty"`
 	GitLab  *GitLabRepo  `json:"gitlab,omitempty"`

api/v1alpha1/scmprovider_types.go

@@ -31,6 +31,7 @@ import (
 var ScmProviderKind = reflect.TypeOf(ScmProvider{}).Name()
 
 // ScmProviderSpec defines the desired state of ScmProvider
+// +kubebuilder:validation:ExactlyOneOf=github;gitlab;forgejo;fake
 type ScmProviderSpec struct {
 	// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
 	// Important: Run "make" to regenerate code after modifying this file

config/crd/bases/promoter.argoproj.io_clusterscmproviders.yaml

@@ -22,6 +22,7 @@ import (
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+
 	"k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/types"
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
@@ -62,6 +63,9 @@ var _ = Describe("ClusterScmProvider Controller", func() {
 						Name:      resourceName,
 						Namespace: "default",
 					},
+					Spec: promoterv1alpha1.ScmProviderSpec{
+						Fake: &promoterv1alpha1.Fake{},
+					},
 					// TODO(user): Specify other spec details if needed.
 				}
 				Expect(k8sClient.Create(ctx, resource)).To(Succeed())

config/crd/bases/promoter.argoproj.io_gitrepositories.yaml

@@ -63,6 +63,7 @@ var _ = Describe("GitRepository Controller", func() {
 						Namespace: "default",
 					},
 					Spec: promoterv1alpha1.GitRepositorySpec{
+						Fake: &promoterv1alpha1.FakeRepo{},
 						ScmProviderRef: promoterv1alpha1.ScmProviderObjectReference{
 							Kind: promoterv1alpha1.ScmProviderKind,
 						},

config/crd/bases/promoter.argoproj.io_scmproviders.yaml

@@ -62,6 +62,9 @@ var _ = Describe("ScmProvider Controller", func() {
 						Name:      resourceName,
 						Namespace: "default",
 					},
+					Spec: promoterv1alpha1.ScmProviderSpec{
+						Fake: &promoterv1alpha1.Fake{},
+					},
 					// TODO(user): Specify other spec details if needed.
 				}
 				Expect(k8sClient.Create(ctx, resource)).To(Succeed())