fix: fallback to create when GitHub check run update returns 404 (#710)

* Initial plan

* Initial exploration: Understand the issue with GitHub Checks API 404 handling

Co-authored-by: crenshaw-dev <[email protected]>

* feat: add 404 fallback for GitHub Checks API update operations

When a CommitStatus was created using the legacy Commit Status API instead
of the Checks API, it may have an invalid check run ID. When attempting to
update such a check run, GitHub returns a 404 error. This change detects
404 errors and falls back to creating a new check run instead, allowing
the transition from Commit Status API to Checks API to work seamlessly.

Co-authored-by: crenshaw-dev <[email protected]>

* chore: revert unrelated package-lock.json changes

Restored package-lock.json files to their original state before the PR.
These changes were not related to the GitHub Checks API fix.

Co-authored-by: crenshaw-dev <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: crenshaw-dev <[email protected]>

Author: Copilot

internal/scms/github/commit_status.go

@@ -2,7 +2,9 @@ package github
 
 import (
 	"context"
+	"errors"
 	"fmt"
+	"net/http"
 	"strconv"
 	"time"
 
@@ -158,6 +160,16 @@ func (cs *CommitStatus) updateCheckRun(ctx context.Context, commitStatus *promot
 	start := time.Now()
 	checkRun, response, err := cs.client.Checks.UpdateCheckRun(ctx, gitRepo.Spec.GitHub.Owner, gitRepo.Spec.GitHub.Name, checkRunID, updateOpts)
 	if err != nil {
+		// Check if the error is a 404 (check run not found)
+		// This can happen when a CommitStatus was created using the legacy Commit Status API
+		// instead of the Checks API, resulting in an invalid check run ID
+		var ghErr *github.ErrorResponse
+		if errors.As(err, &ghErr) && ghErr.Response != nil && ghErr.Response.StatusCode == http.StatusNotFound {
+			logger := log.FromContext(ctx)
+			logger.Info("Check run not found (404), falling back to create operation", "checkRunId", commitStatus.Status.Id)
+			// Fall back to creating a new check run
+			return cs.createCheckRun(ctx, commitStatus)
+		}
 		return nil, fmt.Errorf("failed to update check run: %w", err)
 	}
 	return cs.handleCheckRunResponse(ctx, metrics.SCMOperationUpdate, start, commitStatus, gitRepo, checkRun, response)