fix: flakey tests due to parallelism (#692)

* fix: flakey tests due to parrelleism

Signed-off-by: Zach Aller <[email protected]>

* fix: UI cve

Signed-off-by: Zach Aller <[email protected]>

* fix: UI cve

Signed-off-by: Zach Aller <[email protected]>

---------

Signed-off-by: Zach Aller <[email protected]>

Author: zachaller

internal/controller/promotionstrategy_controller_test.go

@@ -857,12 +857,41 @@ var _ = Describe("PromotionStrategy Controller", func() {
 			Expect(conflictingSha).NotTo(BeEmpty())
 
 			By("Checking that there is no previous-environment commit status created, since no active checks are configured")
+			// List all CTPs owned by this test's PromotionStrategy
+			ctpList := promoterv1alpha1.ChangeTransferPolicyList{}
+			err = k8sClient.List(ctx, &ctpList, client.InNamespace(typeNamespacedName.Namespace))
+			Expect(err).NotTo(HaveOccurred())
+
+			// Build a set of CTP UIDs that belong to this test's PromotionStrategy, so that we can continue to run tests
+			// in parallel without interfering with each other.
+			ctpUIDs := make(map[string]bool)
+			for _, ctp := range ctpList.Items {
+				for _, ownerRef := range ctp.OwnerReferences {
+					if ownerRef.Name == promotionStrategy.Name && ownerRef.UID == promotionStrategy.UID {
+						ctpUIDs[string(ctp.UID)] = true
+						break
+					}
+				}
+			}
+
+			// List all previous-environment commit statuses and filter by ownership
 			csList := promoterv1alpha1.CommitStatusList{}
 			err = k8sClient.List(ctx, &csList, client.MatchingLabels{
 				promoterv1alpha1.CommitStatusLabel: promoterv1alpha1.PreviousEnvironmentCommitStatusKey,
 			})
 			Expect(err).NotTo(HaveOccurred())
-			Expect(len(csList.Items)).To(Equal(0))
+
+			// Filter to only include commit statuses owned by this test's CTPs
+			testCommitStatuses := 0
+			for _, cs := range csList.Items {
+				for _, ownerRef := range cs.OwnerReferences {
+					if ctpUIDs[string(ownerRef.UID)] {
+						testCommitStatuses++
+						break
+					}
+				}
+			}
+			Expect(testCommitStatuses).To(Equal(0))
 
 			By("Waiting for CTPs to reconcile after the conflict and verifying conflict resolution")
 			Eventually(func(g Gomega) {

ui/components-lib/package-lock.json

@@ -11,7 +11,7 @@
   "dependencies": {
     "@types/js-yaml": "^4.0.9",
     "ace-builds": "^1.43.2",
-    "js-yaml": "^4.1.0",
+    "js-yaml": "^4.1.1",
     "react": "18.3.1",
     "react-ace": "^14.0.1",
     "react-dom": "18.3.1",

ui/components-lib/package.json

@@ -34,7 +34,7 @@
   "dependencies": {
     "@types/js-yaml": "^4.0.9",
     "axios": "^1.12.0",
-    "js-yaml": "^4.1.0",
+    "js-yaml": "^4.1.1",
     "react": "18.3.1",
     "react-dom": "18.3.1",
     "zustand": "^3.7.2"