fix: avoid unnecessary Update after Create (#583) (#585)

crenshaw-dev · web-flow · commit f1ca27fec628 · 2025-10-15T10:34:02.000-04:00
Signed-off-by: Michael Crenshaw &lt;350466+crenshaw-dev@users.noreply.github.com&gt;
diff --git a/internal/controller/argocdcommitstatus_controller.go b/internal/controller/argocdcommitstatus_controller.go
@@ -599,12 +599,12 @@ func (r *ArgoCDCommitStatusReconciler) updateAggregatedCommitStatus(ctx context.
 		if client.IgnoreNotFound(err) != nil {
 			return nil, fmt.Errorf("failed to get CommitStatus object: %w", err)
 		}
-		// Create
 		err = r.localClient.Create(ctx, &desiredCommitStatus)
 		logger.Info("Created CommitStatus", "name", desiredCommitStatus.Name, "targetBranch", targetBranch, "sha", sha, "phase", phase, "description", desc)
 		if err != nil {
 			return nil, fmt.Errorf("failed to create CommitStatus object: %w", err)
 		}
+		return &desiredCommitStatus, nil
 	}
 
 	if currentCommitStatus.Spec == desiredCommitStatus.Spec {

Original file line number	Diff line number	Diff line change
`@@ -599,12 +599,12 @@ func (r *ArgoCDCommitStatusReconciler) updateAggregatedCommitStatus(ctx context.`
`599`	`599`	`if client.IgnoreNotFound(err) != nil {`
`600`	`600`	`return nil, fmt.Errorf("failed to get CommitStatus object: %w", err)`
`601`	`601`	`}`
`602`		`- // Create`
`603`	`602`	`err = r.localClient.Create(ctx, &desiredCommitStatus)`
`604`	`603`	`logger.Info("Created CommitStatus", "name", desiredCommitStatus.Name, "targetBranch", targetBranch, "sha", sha, "phase", phase, "description", desc)`
`605`	`604`	`if err != nil {`
`606`	`605`	`return nil, fmt.Errorf("failed to create CommitStatus object: %w", err)`
`607`	`606`	`}`
	`607`	`+ return &desiredCommitStatus, nil`
`608`	`608`	`}`
`609`	`609`
`610`	`610`	`if currentCommitStatus.Spec == desiredCommitStatus.Spec {`