How to use ArgocdCommitStatus in multi environment ovelay

[daudcanugerah]

hi i m using gating promotion to promote staging to production, its 2 environment

so i need to create 2 argocdCommitStatus staging and production?

[crenshaw-dev]

You just need one ArgoCDCommitStatus. It'll automatically infer the apps' environments from their spec.sourceHydrator config and manage one CommitStatus per environment.

[daudcanugerah]

Okay, it works, but it's stuck at the "check pull request" step. I noticed that promoter-previous-env-nginx-apps-environment-prod-c48f6af4-3791ce08 is still pending, even though the CommitStatus from ArgoCDCommitStatus for both production and staging has succeeded.

kind: CommitStatus
metadata:
  annotations:
    promoter.argoproj.io/previous-environment-statuses: |
      nginx-apps-check-app: pending
  creationTimestamp: '2025-07-30T14:57:47Z'
  generation: 4
  labels:
    promoter.argoproj.io/commit-status: promoter-previous-environment
  name: promoter-previous-env-nginx-apps-environment-prod-c48f6af4-3791ce08
  namespace: argocd
  ownerReferences:
    - apiVersion: promoter.argoproj.io/v1alpha1
      blockOwnerDeletion: true
      controller: true
      kind: ChangeTransferPolicy
      name: nginx-apps-environment-prod-c48f6af4
      uid: adbd7937-f264-4482-a2c5-c261bfff637f
  resourceVersion: '18471332221'
  uid: ff5f6d43-b1eb-4fd1-97dc-a57b403c8029
spec:
  description: environment/stag - synced and healthy
  gitRepositoryRef:
    name: nginx-apps-repo
  name: environment/stag - synced and healthy
  phase: pending
  sha: 27690383f827bd7c209a17872a125ba48cca42f4
  url: ''
status:
  conditions:
    - lastTransitionTime: '2025-07-30T14:57:53Z'
      message: Reconciliation succeeded
      observedGeneration: 4
      reason: ReconciliationSuccess
      status: 'True'
      type: Ready
  id: '38089567497'
  phase: pending
  sha: 27690383f827bd7c209a17872a125ba48cca42f4```

<img width="999" height="674" alt="Screenshot 2025-07-30 at 22 04 24" src="https://github.com/user-attachments/assets/43776d96-009e-44c4-a5ad-f3e3d97e59c0" />
<img width="1286" height="512" alt="Screenshot 2025-07-30 at 22 04 48" src="https://github.com/user-attachments/assets/3a05126d-ae35-45a3-b2ff-11f16f62c171" />

```apiVersion: promoter.argoproj.io/v1alpha1
kind: PromotionStrategy
metadata:
  annotations:
    argocd.argoproj.io/tracking-id: r10-root:promoter.argoproj.io/PromotionStrategy:argocd/nginx-apps
  creationTimestamp: '2025-07-30T14:57:47Z'
  generation: 1
  labels:
    app.kubernetes.io/managed-by: argocd
    app.kubernetes.io/name: nginx-apps
  name: nginx-apps
  namespace: argocd
  resourceVersion: '18471337798'
  uid: e477a577-95c1-46c5-a633-7cf791feef0b
spec:
  environments:
    - activeCommitStatuses:
        - key: nginx-apps-check-app
      autoMerge: true
      branch: environment/stag
    - activeCommitStatuses:
        - key: nginx-apps-check-app
      autoMerge: false
      branch: environment/prod
  gitRepositoryRef:
    name: nginx-apps-repo
status:
  conditions:
    - lastTransitionTime: '2025-07-30T14:57:47Z'
      message: Reconciliation succeeded
      observedGeneration: 1
      reason: ReconciliationSuccess
      status: 'True'
      type: Ready
  environments:
    - active:
        commitStatuses:
          - key: nginx-apps-check-app
            phase: pending
        dry:
          repoURL: https://github.com/xxxx/r10-k8s
          sha: 9c31060625a2424ebcec4760629e5c813e7eb051
        hydrated:
          author: ivo-gitops-promoter[bot]
          body: Promote 9c310 to `environment/stag`
          commitTime: '2025-07-30T15:00:33Z'
          sha: 7c1b51359a9c3a6ac02bfc892f9935c4599a3efd
          subject: 'Merge pull request #28 from xxxx/environment/stag-next'
      branch: environment/stag
      proposed:
        dry:
          repoURL: https://github.com/xxx/r10-k8s
          sha: 9c31060625a2424ebcec4760629e5c813e7eb051
        hydrated:
          author: Argo CD
          commitTime: '2025-07-30T15:00:16Z'
          sha: 5f0b067b9708f91f9c60037b14563a8fdb98f0ae
          subject: '[Argo CD Bot] hydrate 9c31060625a2424ebcec4760629e5c813e7eb051'
    - active:
        commitStatuses:
          - key: nginx-apps-check-app
            phase: pending
        dry:
          repoURL: https://github.com/ivosights/r10-k8s
          sha: f1b716d39d795badaf7fb8bb1b91d81bf4d019b5
        hydrated:
          author: daudcanugerah
          body: Promote f1b71 to `environment/prod`
          commitTime: '2025-07-30T14:56:53Z'
          sha: fea9f905987dcd839902d7fc96625e6ab375e478
          subject: 'Merge pull request #27 from xxxx/environment/prod-next'
      branch: environment/prod
      proposed:
        commitStatuses:
          - key: promoter-previous-environment
            phase: pending
        dry:
          repoURL: https://github.com/ivosights/r10-k8s
          sha: 9c31060625a2424ebcec4760629e5c813e7eb051
        hydrated:
          author: Argo CD
          commitTime: '2025-07-30T15:00:38Z'
          sha: 27690383f827bd7c209a17872a125ba48cca42f4
          subject: '[Argo CD Bot] hydrate 9c31060625a2424ebcec4760629e5c813e7eb051'
      pullRequest:
        id: '29'
        prCreationTime: '2025-07-30T15:01:04Z'
        state: open
        url: https://github.com/xxxx/r10-k8s/pull/29```
        
        

[daudcanugerah]

Previously, this happened but I could just merge the PR manually. Now, every closed pull request remains stuck with a "check pending" status.

[daudcanugerah]

Hi @crenshaw-dev

I’ve done some digging. At gitops-promoter/internal/controller/argocdcommitstatus_controller.go:476, the code is statically setting the key to argocd-health. My ArgocdHealth is set to nginx-apps-check-app, but since that key is ignored, in changetransferpolicy_controller.go:319 the code returns 0, causing the CommitStatus to stay pending.

Why is argocd-health hardcoded? is this bug or am i wrong ?

[daudcanugerah]

move to issue #445