fix: mark spec.destination.namespace as optional on ArgoCD application (#256)

Author: onematchfox

argocd/resource_argocd_application_test.go

@@ -251,6 +251,35 @@ ingress:
 	})
 }
 
+func TestAccArgoCDApplication_OptionalDestinationNamespace(t *testing.T) {
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccArgoCDApplication_OptionalDestinationNamespace(acctest.RandomWithPrefix("test-acc")),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttrSet(
+						"argocd_application.simple",
+						"metadata.0.uid",
+					),
+					resource.TestCheckResourceAttr(
+						"argocd_application.simple",
+						"spec.0.destination.0.namespace",
+						"", // optional strings are maintained in state as blank strings
+					),
+				),
+			},
+			{
+				ResourceName:            "argocd_application.simple",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"wait", "cascade"},
+			},
+		},
+	})
+}
+
 func TestAccArgoCDApplication_DirectoryJsonnet(t *testing.T) {
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:          func() { testAccPreCheck(t) },
@@ -1409,6 +1438,30 @@ resource "argocd_application" "ignore_differences_jqpe" {
 	`, name)
 }
 
+func testAccArgoCDApplication_OptionalDestinationNamespace(name string) string {
+	return fmt.Sprintf(`
+resource "argocd_application" "simple" {
+  metadata {
+    name      = "%s"
+    namespace = "argocd"
+  }
+  spec {
+    source {
+      repo_url        = "https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami"
+      chart           = "redis"
+      target_revision = "16.9.11"
+      helm {
+        release_name = "testing"
+      }
+    }
+    destination {
+      server    = "https://kubernetes.default.svc"
+    }
+  }
+}
+`, name)
+}
+
 func testAccArgoCDApplicationNoSyncPolicy(name string) string {
 	return fmt.Sprintf(`
 resource "argocd_application" "simple" {

argocd/schema_application.go

@@ -1254,7 +1254,7 @@ func applicationSpecSchemaV4() *schema.Schema {
 							"namespace": {
 								Type:        schema.TypeString,
 								Description: "Target namespace for the application's resources. The namespace will only be set for namespace-scoped resources that have not set a value for .metadata.namespace.",
-								Required:    true,
+								Optional:    true,
 							},
 							"name": {
 								Type:        schema.TypeString,

docs/resources/application.md

@@ -187,13 +187,10 @@ Optional:
 <a id="nestedblock--spec--destination"></a>
 ### Nested Schema for `spec.destination`
 
-Required:
-
-- `namespace` (String) Target namespace for the application's resources. The namespace will only be set for namespace-scoped resources that have not set a value for .metadata.namespace.
-
 Optional:
 
 - `name` (String) Name of the target cluster. Can be used instead of `server`.
+- `namespace` (String) Target namespace for the application's resources. The namespace will only be set for namespace-scoped resources that have not set a value for .metadata.namespace.
 - `server` (String) URL of the target cluster and must be set to the Kubernetes control plane API.