Skip to content

Commit 50f550a

Browse files
authored
Allow blank Group on cluster resource [white|black]list (#258)
1 parent 274c425 commit 50f550a

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

argocd/resource_argocd_project_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,14 @@ resource "argocd_project" "simple" {
281281
group = "rbac.authorization.k8s.io"
282282
kind = "ClusterRole"
283283
}
284+
cluster_resource_whitelist {
285+
group = ""
286+
kind = "Namespace"
287+
}
288+
cluster_resource_blacklist {
289+
group = ""
290+
kind = "ResourceQuota"
291+
}
284292
cluster_resource_blacklist {
285293
group = "*"
286294
kind = "*"

argocd/validators.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,6 @@ func validateRoleName(value interface{}, key string) (ws []string, es []error) {
7373

7474
func validateGroupName(value interface{}, key string) (ws []string, es []error) {
7575
v := value.(string)
76-
if strings.TrimSpace(v) == "" {
77-
es = append(es, fmt.Errorf("%s: group '%s' is empty", key, v))
78-
}
7976

8077
invalidChars := regexp.MustCompile("[,\n\r\t]")
8178
if invalidChars.MatchString(v) {

0 commit comments

Comments
 (0)