fix: crash when using provider headers (#178)

* fix: crash when using provider headers

* fix(test): flaky TestAccArgoCDCluster_uniqueByServerTrimmed

Author: MrLuje

argocd/provider.go

@@ -221,7 +221,12 @@ func initApiClient(d *schema.ResourceData) (
 		opts.PortForwardNamespace = v.(string)
 	}
 	if v, ok := d.GetOk("headers"); ok {
-		opts.Headers = v.([]string)
+		_headers := v.(*schema.Set).List()
+		var headers = make([]string, len(_headers))
+		for i, _header := range _headers {
+			headers[i] = _header.(string)
+		}
+		opts.Headers = headers
 	}
 	if _, ok := d.GetOk("kubernetes"); ok {
 		opts.KubeOverrides = &clientcmd.ConfigOverrides{}

argocd/resource_argocd_application_test.go

@@ -618,6 +618,25 @@ func TestAccArgoCDApplication_Info(t *testing.T) {
 		}})
 }
 
+func TestProvider_headers(t *testing.T) {
+	name := acctest.RandomWithPrefix("test-acc")
+	resource.Test(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: fmt.Sprintf("%s %s", `
+				provider "argocd" {
+					headers = [
+						"Hello: HiThere",
+					]
+				}`, testAccArgoCDApplicationSimple(name),
+				),
+			},
+		},
+	})
+}
+
 func testAccArgoCDApplicationSimple(name string) string {
 	return fmt.Sprintf(`
 resource "argocd_application" "simple" {

argocd/resource_argocd_cluster_test.go

@@ -506,6 +506,7 @@ resource "argocd_cluster" "cluster_two" {
 func testAccArgoCDClusterTwiceWithSameServerNoNamesTrimmed(server, server2 string) string {
 	return fmt.Sprintf(`
 resource "argocd_cluster" "cluster_one" {
+  name = "server"
   server = "%s"
   config {
     # Uses Kind's bootstrap token whose ttl is 24 hours after cluster bootstrap.
@@ -516,6 +517,7 @@ resource "argocd_cluster" "cluster_one" {
   }
 }
 resource "argocd_cluster" "cluster_two" {
+  name = "server"
   server = "%s"
   config {
     # Uses Kind's bootstrap token whose ttl is 24 hours after cluster bootstrap.