fix: set computed on namespace field (#784)

Signed-off-by: Blake Pettersson <[email protected]>

Author: blakepettersson

docs/data-sources/application.md

@@ -39,19 +39,19 @@ data "argocd_application" "foo" {
 
 Required:
 
-- `name` (String) Name of the applications.argoproj.io, must be unique. Cannot be updated. More info: http://kubernetes.io/docs/user-guide/identifiers#names
+- `name` (String) Name of the applications.argoproj.io, must be unique. Cannot be updated. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
 
 Optional:
 
 - `namespace` (String) Namespace of the applications.argoproj.io, must be unique. Cannot be updated. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/
 
 Read-Only:
 
-- `annotations` (Map of String) An unstructured key value map stored with the cluster secret that may be used to store arbitrary metadata. More info: http://kubernetes.io/docs/user-guide/annotations
+- `annotations` (Map of String) An unstructured key value map stored with the applications.argoproj.io that may be used to store arbitrary metadata. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
 - `generation` (Number) A sequence number representing a specific generation of the desired state.
-- `labels` (Map of String) Map of string keys and values that can be used to organize and categorize (scope and select) the cluster secret. May match selectors of replication controllers and services. More info: http://kubernetes.io/docs/user-guide/labels
-- `resource_version` (String) An opaque value that represents the internal version of this applications.argoproj.io that can be used by clients to determine when applications.argoproj.io has changed. Read more: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency
-- `uid` (String) The unique in time and space value for this applications.argoproj.io. More info: http://kubernetes.io/docs/user-guide/identifiers#uids
+- `labels` (Map of String) Map of string keys and values that can be used to organize and categorize (scope and select) the applications.argoproj.io. May match selectors of replication controllers and services. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels
+- `resource_version` (String) An opaque value that represents the internal version of this applications.argoproj.io that can be used by clients to determine when the applications.argoproj.io has changed. Read more: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency
+- `uid` (String) The unique in time and space value for this applications.argoproj.io. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#uids
 
 
 <a id="nestedatt--spec"></a>

docs/resources/project.md

@@ -148,19 +148,19 @@ resource "argocd_project" "myproject" {
 
 Required:
 
-- `name` (String) Name of the appproject, must be unique. Cannot be updated. More info: http://kubernetes.io/docs/user-guide/identifiers#names
+- `name` (String) Name of the appproject, must be unique. Cannot be updated. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
 
 Optional:
 
-- `annotations` (Map of String) An unstructured key value map stored with the cluster secret that may be used to store arbitrary metadata. More info: http://kubernetes.io/docs/user-guide/annotations
-- `labels` (Map of String) Map of string keys and values that can be used to organize and categorize (scope and select) the cluster secret. May match selectors of replication controllers and services. More info: http://kubernetes.io/docs/user-guide/labels
+- `annotations` (Map of String) An unstructured key value map stored with the appproject that may be used to store arbitrary metadata. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
+- `labels` (Map of String) Map of string keys and values that can be used to organize and categorize (scope and select) the appproject. May match selectors of replication controllers and services. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels
 - `namespace` (String) Namespace of the appproject, must be unique. Cannot be updated. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/
 
 Read-Only:
 
 - `generation` (Number) A sequence number representing a specific generation of the desired state.
-- `resource_version` (String) An opaque value that represents the internal version of this appproject that can be used by clients to determine when appproject has changed. Read more: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency
-- `uid` (String) The unique in time and space value for this appproject. More info: http://kubernetes.io/docs/user-guide/identifiers#uids
+- `resource_version` (String) An opaque value that represents the internal version of this appproject that can be used by clients to determine when the appproject has changed. Read more: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency
+- `uid` (String) The unique in time and space value for this appproject. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#uids
 
 
 <a id="nestedblock--spec"></a>

internal/provider/model_metadata.go

@@ -31,7 +31,7 @@ func objectMetaSchemaAttribute(objectName string, computed bool) schema.Attribut
 		Required:            true,
 		Attributes: map[string]schema.Attribute{
 			"name": schema.StringAttribute{
-				MarkdownDescription: fmt.Sprintf("Name of the %s, must be unique. Cannot be updated. More info: http://kubernetes.io/docs/user-guide/identifiers#names", objectName),
+				MarkdownDescription: fmt.Sprintf("Name of the %s, must be unique. Cannot be updated. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names", objectName),
 				Required:            true,
 				PlanModifiers: []planmodifier.String{
 					stringplanmodifier.RequiresReplace(),
@@ -52,7 +52,7 @@ func objectMetaSchemaAttribute(objectName string, computed bool) schema.Attribut
 				},
 			},
 			"annotations": schema.MapAttribute{
-				MarkdownDescription: "An unstructured key value map stored with the cluster secret that may be used to store arbitrary metadata. More info: http://kubernetes.io/docs/user-guide/annotations",
+				MarkdownDescription: fmt.Sprintf("An unstructured key value map stored with the %s that may be used to store arbitrary metadata. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/", objectName),
 				Computed:            computed,
 				Optional:            !computed,
 				ElementType:         types.StringType,
@@ -61,7 +61,7 @@ func objectMetaSchemaAttribute(objectName string, computed bool) schema.Attribut
 				},
 			},
 			"labels": schema.MapAttribute{
-				MarkdownDescription: "Map of string keys and values that can be used to organize and categorize (scope and select) the cluster secret. May match selectors of replication controllers and services. More info: http://kubernetes.io/docs/user-guide/labels",
+				MarkdownDescription: fmt.Sprintf("Map of string keys and values that can be used to organize and categorize (scope and select) the %s. May match selectors of replication controllers and services. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels", objectName),
 				Computed:            computed,
 				Optional:            !computed,
 				ElementType:         types.StringType,
@@ -74,18 +74,18 @@ func objectMetaSchemaAttribute(objectName string, computed bool) schema.Attribut
 				Computed:            true,
 			},
 			"resource_version": schema.StringAttribute{
-				MarkdownDescription: fmt.Sprintf("An opaque value that represents the internal version of this %s that can be used by clients to determine when %s has changed. Read more: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency", objectName, objectName),
+				MarkdownDescription: fmt.Sprintf("An opaque value that represents the internal version of this %s that can be used by clients to determine when the %s has changed. Read more: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency", objectName, objectName),
 				Computed:            true,
 			},
 			"uid": schema.StringAttribute{
-				MarkdownDescription: fmt.Sprintf("The unique in time and space value for this %s. More info: http://kubernetes.io/docs/user-guide/identifiers#uids", objectName),
+				MarkdownDescription: fmt.Sprintf("The unique in time and space value for this %s. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#uids", objectName),
 				Computed:            true,
 			},
 		},
 	}
 }
 
-func objectMetaSchemaListBlock(objectName string, computed bool) schema.Block {
+func objectMetaSchemaListBlock(objectName string) schema.Block {
 	return schema.ListNestedBlock{
 		MarkdownDescription: "Standard Kubernetes object metadata. For more info see the [Kubernetes reference](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata).",
 		Validators: []validator.List{
@@ -96,7 +96,7 @@ func objectMetaSchemaListBlock(objectName string, computed bool) schema.Block {
 		NestedObject: schema.NestedBlockObject{
 			Attributes: map[string]schema.Attribute{
 				"name": schema.StringAttribute{
-					MarkdownDescription: fmt.Sprintf("Name of the %s, must be unique. Cannot be updated. More info: http://kubernetes.io/docs/user-guide/identifiers#names", objectName),
+					MarkdownDescription: fmt.Sprintf("Name of the %s, must be unique. Cannot be updated. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names", objectName),
 					Required:            true,
 					PlanModifiers: []planmodifier.String{
 						stringplanmodifier.RequiresReplace(),
@@ -108,7 +108,7 @@ func objectMetaSchemaListBlock(objectName string, computed bool) schema.Block {
 				"namespace": schema.StringAttribute{
 					MarkdownDescription: fmt.Sprintf("Namespace of the %s, must be unique. Cannot be updated. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/", objectName),
 					Optional:            true,
-					Computed:            computed,
+					Computed:            true,
 					PlanModifiers: []planmodifier.String{
 						stringplanmodifier.RequiresReplace(),
 					},
@@ -117,18 +117,16 @@ func objectMetaSchemaListBlock(objectName string, computed bool) schema.Block {
 					},
 				},
 				"annotations": schema.MapAttribute{
-					MarkdownDescription: "An unstructured key value map stored with the cluster secret that may be used to store arbitrary metadata. More info: http://kubernetes.io/docs/user-guide/annotations",
-					Computed:            computed,
-					Optional:            !computed,
+					MarkdownDescription: fmt.Sprintf("An unstructured key value map stored with the %s that may be used to store arbitrary metadata. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/", objectName),
+					Optional:            true,
 					ElementType:         types.StringType,
 					Validators: []validator.Map{
 						validators.MetadataAnnotations(),
 					},
 				},
 				"labels": schema.MapAttribute{
-					MarkdownDescription: "Map of string keys and values that can be used to organize and categorize (scope and select) the cluster secret. May match selectors of replication controllers and services. More info: http://kubernetes.io/docs/user-guide/labels",
-					Computed:            computed,
-					Optional:            !computed,
+					MarkdownDescription: fmt.Sprintf("Map of string keys and values that can be used to organize and categorize (scope and select) the %s. May match selectors of replication controllers and services. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels", objectName),
+					Optional:            true,
 					ElementType:         types.StringType,
 					Validators: []validator.Map{
 						validators.MetadataLabels(),
@@ -139,11 +137,11 @@ func objectMetaSchemaListBlock(objectName string, computed bool) schema.Block {
 					Computed:            true,
 				},
 				"resource_version": schema.StringAttribute{
-					MarkdownDescription: fmt.Sprintf("An opaque value that represents the internal version of this %s that can be used by clients to determine when %s has changed. Read more: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency", objectName, objectName),
+					MarkdownDescription: fmt.Sprintf("An opaque value that represents the internal version of this %s that can be used by clients to determine when the %s has changed. Read more: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency", objectName, objectName),
 					Computed:            true,
 				},
 				"uid": schema.StringAttribute{
-					MarkdownDescription: fmt.Sprintf("The unique in time and space value for this %s. More info: http://kubernetes.io/docs/user-guide/identifiers#uids", objectName),
+					MarkdownDescription: fmt.Sprintf("The unique in time and space value for this %s. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#uids", objectName),
 					Computed:            true,
 				},
 			},

internal/provider/model_project.go

@@ -87,7 +87,7 @@ type syncWindowModel struct {
 
 func projectSchemaBlocks() map[string]schema.Block {
 	return map[string]schema.Block{
-		"metadata": objectMetaSchemaListBlock("appproject", false),
+		"metadata": objectMetaSchemaListBlock("appproject"),
 		"spec": schema.ListNestedBlock{
 			Description: "ArgoCD AppProject spec.",
 			Validators: []validator.List{
@@ -392,6 +392,12 @@ func newProjectSpec(spec *v1alpha1.AppProjectSpec) projectSpecModel {
 		Description: types.StringValue(spec.Description),
 	}
 
+	if spec.Description != "" {
+		ps.Description = types.StringValue(spec.Description)
+	} else {
+		ps.Description = types.StringNull()
+	}
+
 	// Convert source repos
 	if len(spec.SourceRepos) > 0 {
 		ps.SourceRepos = make([]types.String, len(spec.SourceRepos))

internal/provider/resource_project_test.go

@@ -1471,3 +1471,81 @@ resource "argocd_project" "migration" {
 }
 	`, name)
 }
+
+// TestAccArgoCDProject_ProviderUpgradeStateMigration_WithoutNamespace tests the specific
+// case reported in issue #783 where projects created without an explicit namespace field
+// in v7.12.1 cause forced replacement when upgrading to v7.12.3+.
+// The namespace should be computed from the API response without causing drift.
+func TestAccArgoCDProject_ProviderUpgradeStateMigration_WithoutNamespace(t *testing.T) {
+	name := acctest.RandomWithPrefix("test-acc-migrate-no-ns")
+	config := testAccArgoCDProjectForStateMigrationWithoutNamespace(name)
+
+	resource.Test(t, resource.TestCase{
+		Steps: []resource.TestStep{
+			{
+				// Step 1: Create project using old SDK-based provider (v7.12.1)
+				// without specifying namespace in metadata (this is the key scenario)
+				ExternalProviders: map[string]resource.ExternalProvider{
+					"argocd": {
+						VersionConstraint: "7.12.1",
+						Source:            "argoproj-labs/argocd",
+					},
+				},
+				Config: config,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("argocd_project.tech", "metadata.0.name", name),
+					resource.TestCheckResourceAttrSet("argocd_project.tech", "metadata.0.uid"),
+				),
+			},
+			{
+				// Step 2: Upgrade to new framework-based provider
+				ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
+				Config:                   config,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("argocd_project.tech", "metadata.0.name", name),
+					resource.TestCheckResourceAttr("argocd_project.tech", "spec.0.source_repos.#", "1"),
+					resource.TestCheckResourceAttr("argocd_project.tech", "spec.0.destination.#", "1"),
+					resource.TestCheckResourceAttr("argocd_project.tech", "spec.0.cluster_resource_whitelist.#", "1"),
+					// Namespace should be computed from API, not forcing replacement
+					resource.TestCheckResourceAttr("argocd_project.tech", "metadata.0.namespace", "argocd"),
+				),
+			},
+			{
+				// Step 3: Verify no unexpected plan changes after migration (issue #783)
+				// This should NOT show a forced replacement due to namespace changing
+				ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
+				Config:                   config,
+				ConfigPlanChecks: resource.ConfigPlanChecks{
+					PreApply: []plancheck.PlanCheck{
+						plancheck.ExpectEmptyPlan(),
+					},
+				},
+			},
+		},
+	})
+}
+
+func testAccArgoCDProjectForStateMigrationWithoutNamespace(name string) string {
+	return fmt.Sprintf(`
+resource "argocd_project" "tech" {
+  metadata {
+    name = "%s"
+    # NOTE: namespace is intentionally NOT specified here to test issue #783
+  }
+
+  spec {
+    source_repos = ["*"]
+
+    destination {
+      server    = "https://kubernetes.default.svc"
+      namespace = "*"
+    }
+
+    cluster_resource_whitelist {
+      group = "*"
+      kind  = "*"
+    }
+  }
+}
+	`, name)
+}