chore(deps): update golangci/golangci-lint-action action to v6.5.0 (#576)

* chore(deps): update golangci/golangci-lint-action action to v6.5.0

* chore: Address golangci findings with new version

Signed-off-by: Marco Maurer <[email protected]>

---------

Signed-off-by: Marco Maurer <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Marco Maurer <[email protected]>

Author: renovate[bot]

.github/workflows/tests.yml

@@ -27,9 +27,9 @@ jobs:
     - name: Build provider
       run: make build
     - name: Run linters
-      uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # v6.1.1
+      uses: golangci/golangci-lint-action@2226d7cb06a077cd73e56eedd38eecad18e5d837 # v6.5.0
       with:
-        version: v1.59.1
+        version: v1.64.6
 
   generate:
     runs-on: ubuntu-24.04

.golangci.yml

@@ -12,7 +12,6 @@ issues:
     - path: _test\.go
       linters:
         - contextcheck
-  max-per-linter: 0
   max-same-issues: 0
 
 linters:
@@ -22,12 +21,12 @@ linters:
     - asciicheck
     - containedctx
     - contextcheck
+    - copyloopvar
     - dogsled
     - durationcheck
     - errcheck
     - errname
     - errorlint
-    - exportloopref
     - goconst
     - gocritic
     - gofmt
@@ -44,12 +43,12 @@ linters:
     - predeclared
     - staticcheck
     - stylecheck
-    - tenv
     - tparallel
     - typecheck
     - unconvert
     - unparam
     - unused
+    - usetesting
     - whitespace
     - wsl
 
@@ -99,7 +98,6 @@ linters-settings:
       - strings.SplitN
   nolintlint:
     allow-unused: false
-    allow-leading-space: false
     require-explanation: true
     require-specific: true
     allow-no-explanation:

argocd/schema_application_test.go

@@ -547,8 +547,6 @@ func TestUpgradeSchemaApplication_V3V4(t *testing.T) {
 	}
 
 	for _, tc := range cases {
-		tc := tc
-
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

argocd/schema_project_test.go

@@ -128,8 +128,6 @@ func TestResourceArgoCDProjectStateUpgradeV0(t *testing.T) {
 	}
 
 	for _, tc := range cases {
-		tc := tc
-
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

argocd/structure_metadata_test.go

@@ -21,9 +21,6 @@ func TestMetadataIsInternalKey(t *testing.T) {
 		{"notified.notifications.argoproj.io", true},
 	}
 	for i, tc := range testCases {
-		i := i
-		tc := tc
-
 		t.Run(fmt.Sprintf("%d", i), func(t *testing.T) {
 			t.Parallel()
 

argocd/validators_test.go

@@ -30,8 +30,6 @@ func Test_validateSSHPrivateKey(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		tt := tt
-
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/server_interface_test.go

@@ -85,8 +85,6 @@ func TestServerInterface_isFeatureSupported(t *testing.T) {
 	}
 
 	for _, tt := range tests {
-		tt := tt
-
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()