Skip to content

Commit f703e45

Browse files
authored
Add ArgoCD 1.8.x to acceptance testing matrix (#43)
* test against argocd 1.8.x * build and test against Go 1.15, update local development testing ArgoCD version to 1.8.2 * updated README about container images side-loading and OS limits during local development * chore: removed useless workarounds intended for argocd 1.5.x
2 parents 2d88e14 + bbf6e11 commit f703e45

File tree

7 files changed

+22
-2626
lines changed

7 files changed

+22
-2626
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- name: Set up Go
1818
uses: actions/setup-go@v2
1919
with:
20-
go-version: 1.14
20+
go-version: 1.15
2121

2222
- name: Import GPG key
2323
id: import_gpg

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ jobs:
1414
strategy:
1515
fail-fast: false
1616
matrix:
17-
argocd_version: ["v1.7.8", "v1.6.2", "v1.5.8"]
17+
argocd_version: ["v.1.8.2", "v1.7.11", "v1.6.2"]
1818
steps:
1919
- uses: actions/checkout@v2
2020
- uses: actions/setup-go@v1
2121
with:
22-
go-version: 1.14
22+
go-version: 1.15
2323
id: go
2424
- name: Restore Go cache
2525
uses: actions/cache@v1

README.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,19 @@ make testacc
319319
make testacc_clean_env
320320
```
321321

322+
**Note:** to speed up testing environment setup, it is highly recommended you pull all needed container images into your local registry first, as the setup tries to sideload the images within the Kind cluster upon cluster creation.
323+
324+
For example if you use Docker as your local container runtime:
325+
```shell
326+
docker pull argoproj/argocd:v1.8.2
327+
docker pull ghcr.io/dexidp/dex:v2.27.0
328+
docker pull redis:5.0.10-alpine
329+
```
330+
331+
#### Troubleshooting during local development
332+
333+
* **"too many open files":** Running all acceptance tests in parallel (the default) may open a lot of files and sockets, therefore ensure your local workstation [open files/sockets limits are tuned accordingly](https://k6.io/docs/misc/fine-tuning-os).
334+
322335
---
323336

324337
## Credits

0 commit comments

Comments
 (0)