feat(controller): add --configmap-name flag to override controller ConfigMap

The controller ConfigMap name was hardcoded to "argo-rollouts-config" with
no way to override it. This adds a --configmap-name flag so operators can
specify an alternative name, which is useful when running multiple controller
instances in the same namespace or when the default name conflicts with
existing resources.

Signed-off-by: Alex Kazantcev <aleksandr.kazantcev@ticketmaster.co.uk>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: a1exx-k

cmd/rollouts-controller/main.go

@@ -88,6 +88,7 @@ func newCommand() *cobra.Command {
 		selfServiceNotificationEnabled bool
 		controllersEnabled             []string
 		pprofAddress                   string
+		rolloutsConfigMapName          string
 	)
 	electOpts := controller.NewLeaderElectionOptions()
 	var command = cobra.Command{
@@ -119,6 +120,7 @@ func newCommand() *cobra.Command {
 			defaults.SetAppMeshCRDVersion(appmeshCRDVersion)
 			defaults.SetTraefikAPIGroup(traefikAPIGroup)
 			defaults.SetTraefikVersion(traefikVersion)
+			defaults.SetRolloutsConfigMapName(rolloutsConfigMapName)
 
 			config, err := clientConfig.ClientConfig()
 			errors.CheckError(err)
@@ -340,6 +342,7 @@ func newCommand() *cobra.Command {
 	command.Flags().BoolVar(&selfServiceNotificationEnabled, "self-service-notification-enabled", false, "Allows rollouts controller to pull notification config from the namespace that the rollout resource is in. This is useful for self-service notification.")
 	command.Flags().StringSliceVar(&controllersEnabled, "controllers", nil, "Explicitly specify the list of controllers to run, currently only supports 'analysis', eg. --controller=analysis. Default: all controllers are enabled")
 	command.Flags().StringVar(&pprofAddress, "enable-pprof-address", "", "Enable pprof profiling on controller by providing a server address.")
+	command.Flags().StringVar(&rolloutsConfigMapName, "configmap-name", defaults.DefaultRolloutsConfigMapName, "Name of the ConfigMap used to configure the controller.")
 	return &command
 }
 

cmd/rollouts-controller/main_test.go

@@ -4,6 +4,8 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+
+	"github.com/argoproj/argo-rollouts/utils/defaults"
 )
 
 func TestMetricsPortFlagCompatibility(t *testing.T) {
@@ -19,3 +21,11 @@ func TestMetricsPortFlagCompatibility(t *testing.T) {
 	// Test that deprecated flag is marked as deprecated
 	assert.True(t, metricsportFlag.Deprecated != "", "metricsport flag should be marked as deprecated")
 }
+
+func TestConfigMapNameFlag(t *testing.T) {
+	cmd := newCommand()
+
+	configmapNameFlag := cmd.Flags().Lookup("configmap-name")
+	assert.NotNil(t, configmapNameFlag, "configmap-name flag should exist")
+	assert.Equal(t, defaults.DefaultRolloutsConfigMapName, configmapNameFlag.DefValue, "configmap-name flag should default to %s", defaults.DefaultRolloutsConfigMapName)
+}

controller/controller.go

@@ -233,7 +233,7 @@ func NewAnalysisManager(
 		onlyAnalysisMode:              true,
 	}
 
-	_, err := rolloutsConfig.InitializeConfig(kubeclientset, defaults.DefaultRolloutsConfigMapName)
+	_, err := rolloutsConfig.InitializeConfig(kubeclientset, defaults.GetRolloutsConfigMapName())
 	if err != nil {
 		log.Fatalf("Failed to init config: %v", err)
 	}
@@ -443,7 +443,7 @@ func NewManager(
 		notificationSecretInformerFactory:    notificationSecretInformerFactory,
 	}
 
-	_, err := rolloutsConfig.InitializeConfig(kubeclientset, defaults.DefaultRolloutsConfigMapName)
+	_, err := rolloutsConfig.InitializeConfig(kubeclientset, defaults.GetRolloutsConfigMapName())
 	if err != nil {
 		log.Fatalf("Failed to init config: %v", err)
 	}

utils/defaults/defaults.go

@@ -80,6 +80,7 @@ var (
 	appmeshCRDVersion            = DefaultAppMeshCRDVersion
 	defaultMetricCleanupDelay    = DefaultMetricCleanupDelay
 	defaultDescribeTagsLimit     = DefaultDescribeTagsLimit
+	rolloutsConfigMapName        = DefaultRolloutsConfigMapName
 )
 
 const (
@@ -366,3 +367,13 @@ func GetDescribeTagsLimit() int {
 func SetDescribeTagsLimit(limit int) {
 	defaultDescribeTagsLimit = limit
 }
+
+// SetRolloutsConfigMapName overrides the name of the ConfigMap used to configure the controller.
+func SetRolloutsConfigMapName(name string) {
+	rolloutsConfigMapName = name
+}
+
+// GetRolloutsConfigMapName returns the name of the ConfigMap used to configure the controller.
+func GetRolloutsConfigMapName() string {
+	return rolloutsConfigMapName
+}

utils/defaults/defaults_test.go

@@ -429,4 +429,10 @@ func TestSetDefaults(t *testing.T) {
 	assert.Equal(t, DefaultDescribeTagsLimit, GetDescribeTagsLimit())
 	SetDescribeTagsLimit(2)
 	assert.Equal(t, 2, GetDescribeTagsLimit())
+
+	assert.Equal(t, DefaultRolloutsConfigMapName, GetRolloutsConfigMapName())
+	SetRolloutsConfigMapName("my-custom-config")
+	assert.Equal(t, "my-custom-config", GetRolloutsConfigMapName())
+	SetRolloutsConfigMapName(DefaultRolloutsConfigMapName)
+	assert.Equal(t, DefaultRolloutsConfigMapName, GetRolloutsConfigMapName())
 }