feat(deprecation): remove 3.6 deprecated features for 4.0 (#14189)

Signed-off-by: Alan Clucas <[email protected]>

Author: Joibel

.features/pending/deprecate-36.md

@@ -0,0 +1,6 @@
+Description: Deprecate singular in favour of plural items
+Authors: [Alan Clucas](https://github.com/Joibel)
+Component: General
+Issues: 14977
+
+Deprecation: remove singluar `mutex`, `semaphore` and `schedule` from the specs, all were replaced by the plural version in 3.6

api/jsonschema/schema.json

@@ -104,7 +104,7 @@ func backfillCronWorkflow(ctx context.Context, cronWFName string, cliOps backfil
 	if err != nil {
 		return err
 	}
-	cronTab, err := cron.ParseStandard(cronWF.Spec.Schedule)
+	cronTab, err := cron.ParseStandard(cronWF.Spec.GetScheduleString())
 	if err != nil {
 		return err
 	}
@@ -121,7 +121,7 @@ func backfillCronWorkflow(ctx context.Context, cronWFName string, cliOps backfil
 	if !cliOps.parallel {
 		wf.Spec.Priority = &priority
 		wf.Spec.Synchronization = &v1alpha1.Synchronization{
-			Mutex: &v1alpha1.Mutex{Name: cliOps.name},
+			Mutexes: []*v1alpha1.Mutex{{Name: cliOps.name}},
 		}
 	}
 	wf.Spec.Arguments.Parameters = append(wf.Spec.Arguments.Parameters, param)

api/openapi-spec/swagger.json

@@ -61,7 +61,8 @@ func CreateCronWorkflows(ctx context.Context, filePaths []string, cliOpts *cliCr
 
 	for _, cronWf := range cronWorkflows {
 		if cliOpts.schedule != "" {
-			cronWf.Spec.Schedule = cliOpts.schedule
+			// This option replaces the schedule
+			cronWf.Spec.Schedules = []string{cliOpts.schedule}
 		}
 
 		newWf := wfv1.Workflow{Spec: cronWf.Spec.WorkflowSpec}

cmd/argo/commands/cron/backfill.go

@@ -23,7 +23,7 @@ import (
 func GetNextRuntime(ctx context.Context, cwf *v1alpha1.CronWorkflow) (time.Time, error) {
 	var nextRunTime time.Time
 	now := time.Now().UTC()
-	for _, schedule := range cwf.Spec.GetSchedulesWithTimezone(ctx) {
+	for _, schedule := range cwf.Spec.GetSchedulesWithTimezone() {
 		cronSchedule, err := cron.ParseStandard(schedule)
 		if err != nil {
 			return time.Time{}, err

cmd/argo/commands/cron/create.go

@@ -44,8 +44,7 @@ You can use `CronWorkflow.spec.workflowMetadata` to add `labels` and `annotation
 
 | Option Name                  | Default Value          | Description |
 |:----------------------------:|:----------------------:|-------------|
-| `schedule`                   | None | [Cron schedule](#cron-schedule-syntax) to run `Workflows`. Example: `5 4 * * *`. Deprecated, use `schedules`. |
-| `schedules`                  | None | v3.6 and after: List of [Cron schedules](#cron-schedule-syntax) to run `Workflows`. Example: `5 4 * * *`, `0 1 * * *`. Either `schedule` or `schedules` must be provided. |
+| `schedules`                  | None | v3.6 and after: List of [Cron schedules](#cron-schedule-syntax) to run `Workflows`. Example: `5 4 * * *`, `0 1 * * *`. Required to be a non-empty list. |
 | `timezone`                   | Machine timezone       | [IANA Timezone](https://en.wikipedia.org/wiki/List_of_tz_database_time_zones) to run `Workflows`. Example: `America/Los_Angeles` |
 | `suspend`                    | `false`                | If `true` Workflow scheduling will not occur. Can be set from the CLI, GitOps, or directly |
 | `concurrencyPolicy`          | `Allow`                | What to do if multiple `Workflows` are scheduled at the same time. `Allow`: allow all, `Replace`: remove all old before scheduling new, `Forbid`: do not allow any new while there are old  |

cmd/argo/commands/cron/util.go

@@ -3805,9 +3805,7 @@ of the first container processes are calculated.
 
 | Name | Type | Go type | Required | Default | Description | Example |
 |------|------|---------|:--------:| ------- |-------------|---------|
-| mutex | [Mutex](#mutex)| `Mutex` |  | |  |  |
 | mutexes | [][Mutex](#mutex)| `[]*Mutex` |  | | v3.6 and after: Mutexes holds the list of Mutex lock details |  |
-| semaphore | [SemaphoreRef](#semaphore-ref)| `SemaphoreRef` |  | |  |  |
 | semaphores | [][SemaphoreRef](#semaphore-ref)| `[]*SemaphoreRef` |  | | v3.6 and after: Semaphores holds the list of Semaphores configuration |  |