test: refactor E2E examples tests and fix Makefile (#14094)

Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>

Author: MasonM

.github/workflows/ci-build.yaml

@@ -61,7 +61,6 @@ jobs:
               - sdks/**
               # example test suite
               - examples/**
-              - hack/test-examples.sh
             codegen:
               - *common
               # generated files

Makefile

@@ -51,7 +51,7 @@ endif
 # -- install & run options
 PROFILE               ?= minimal
 KUBE_NAMESPACE        ?= argo # namespace where Kubernetes resources/RBAC will be installed
-PLUGINS               ?= $(shell [ $PROFILE = plugins ] && echo false || echo true)
+PLUGINS               ?= $(shell [ $(PROFILE) = plugins ] && echo true || echo false)
 UI                    ?= false # start the UI with HTTP
 UI_SECURE             ?= false # start the UI with HTTPS
 API                   ?= $(UI) # start the Argo Server
@@ -608,10 +608,6 @@ test-cli: ./dist/argo
 test-%:
 	E2E_WAIT_TIMEOUT=$(E2E_WAIT_TIMEOUT) go test -failfast -v -timeout $(E2E_SUITE_TIMEOUT) -count 1 --tags $* -parallel $(E2E_PARALLEL) ./test/e2e
 
-.PHONY: test-examples
-test-examples:
-	./hack/test-examples.sh
-
 .PHONY: test-%-sdk
 test-%-sdk:
 	make --directory sdks/$* install test -B

examples/webhdfs-input-output-artifacts.yaml

@@ -49,7 +49,6 @@ spec:
       artifacts:
       - name: my-art2
         path: /my-artifact
-        overwrite: true
         http:
           # below is an example on how to use authentication via certificates
           # clientCert.clientCertSecret: points to a kubernetes secret named cert-sec with a data entry of "certificate.pem"

hack/test-examples.sh

@@ -1392,7 +1392,6 @@ func (s *CLISuite) TestCronCommands() {
 			assert.Contains(t, output, "5 5 5 * *")
 			assert.Contains(t, output, "Replace")
 			assert.Contains(t, output, "whalesay")
-			assert.NotContains(t, output, "argosay")
 		})
 	})
 	s.Run("Create Parameter Override", func() {

test/e2e/cli_test.go

@@ -26,6 +26,5 @@ spec:
           parameters:
             - name: message
         container:
-          image: python:alpine3.6
-          command: [ "sh", -c ]
-          args: [ "echo {{inputs.parameters.message}}" ]
+          image: argoproj/argosay:v2
+          args: [ "echo", "{{inputs.parameters.message}}" ]

test/e2e/cron/basic-update-template.yaml

@@ -18,9 +18,8 @@ spec:
     templates:
       - name: whalesay
         container:
-          image: python:alpine3.6
-          command: ["sh", -c]
-          args: ["echo hello"]
+          image: argoproj/argosay:v2
+          args: ["echo", "hello"]
 
 ---
 

test/e2e/cron/cron-and-malformed-template.yaml

@@ -25,6 +25,5 @@ spec:
           parameters:
             - name: message
         container:
-          image: python:alpine3.6
-          command: ["sh", -c]
-          args: ["echo {{inputs.parameters.message}}"]
+          image: argoproj/argosay:v2
+          args: ["echo", "{{inputs.parameters.message}}"]

test/e2e/cron/param.yaml

@@ -454,8 +454,7 @@ spec:
 }
 
 func (s *CronSuite) TestMalformedCronWorkflow() {
-	s.Given().
-		Exec("kubectl", []string{"apply", "-f", "testdata/malformed/malformed-cronworkflow.yaml"}, fixtures.ErrorOutput("unknown field \"spec.workflowSpec.arguments.parameters.someParam\""))
+	s.Given().KubectlApply("testdata/malformed/malformed-cronworkflow.yaml", fixtures.ErrorOutput(".spec.workflowSpec.arguments.parameters: expected list"))
 }
 
 func TestCronSuite(t *testing.T) {

test/e2e/cron_test.go

@@ -0,0 +1,47 @@
+//go:build examples
+
+package e2e
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/suite"
+
+	"github.com/argoproj/argo-workflows/v3/test/e2e/fixtures"
+	fileutil "github.com/argoproj/argo-workflows/v3/util/file"
+	"github.com/argoproj/argo-workflows/v3/workflow/common"
+)
+
+type ExamplesSuite struct {
+	fixtures.E2ESuite
+}
+
+func (s *ExamplesSuite) BeforeTest(suiteName, testName string) {
+	s.E2ESuite.BeforeTest(suiteName, testName)
+	s.Given().KubectlApply("../../examples/configmaps/simple-parameters-configmap.yaml", fixtures.NoError)
+}
+
+func (s *ExamplesSuite) TestExampleWorkflows() {
+	err := fileutil.WalkManifests("../../examples", func(path string, data []byte) error {
+		wfs, err := common.SplitWorkflowYAMLFile(data, true)
+		if err != nil {
+			s.T().Fatalf("Error parsing %s: %v", path, err)
+		}
+		for _, wf := range wfs {
+			if _, ok := wf.GetLabels()["workflows.argoproj.io/test"]; ok {
+				s.T().Logf("Found example workflow at %s with test label\n", path)
+				s.Given().
+					ExampleWorkflow(&wf).
+					When().
+					SubmitWorkflow().
+					WaitForWorkflow(fixtures.ToBeSucceeded)
+			}
+		}
+		return nil
+	})
+	s.CheckError(err)
+}
+
+func TestExamplesSuite(t *testing.T) {
+	suite.Run(t, new(ExamplesSuite))
+}