format: remove duplicate prefix on cutom message

Signed-off-by: Atif Ali <[email protected]>

Author: aali309

pkg/sync/sync_context.go

@@ -1079,7 +1079,7 @@ func (sc *syncContext) applyObject(t *syncTask, dryRun, validate bool) (common.R
 				if len(changes) > 0 {
 					// Sort the changes to ensure consistent order
 					sort.Strings(changes)
-					return common.ResultCodeSyncFailed, fmt.Sprintf("one or more objects failed to apply, reason: attempting to change immutable fields:\n%s\n\nForbidden: updates to statefulset spec for fields other than 'replicas', 'ordinals', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden",
+					return common.ResultCodeSyncFailed, fmt.Sprintf("attempting to change immutable fields:\n%s\n\nForbidden: updates to statefulset spec for fields other than 'replicas', 'ordinals', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden",
 						strings.Join(changes, "\n"))
 				}
 			}

pkg/sync/sync_context_test.go

@@ -2057,7 +2057,7 @@ func TestStatefulSetImmutableFieldErrors(t *testing.T) {
 			desiredSpec: map[string]interface{}{
 				"serviceName": "new-svc",
 			},
-			expectedMessage: `one or more objects failed to apply, reason: attempting to change immutable fields:
+			expectedMessage: `attempting to change immutable fields:
    - serviceName:
       from: "old-svc"
       to:   "new-svc"
@@ -2098,7 +2098,7 @@ Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordina
 					},
 				},
 			},
-			expectedMessage: `one or more objects failed to apply, reason: attempting to change immutable fields:
+			expectedMessage: `attempting to change immutable fields:
    - volumeClaimTemplates:
       from: [data(1Gi)]
       to:   [data(2Gi)]
@@ -2121,7 +2121,7 @@ Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordina
 					},
 				},
 			},
-			expectedMessage: `one or more objects failed to apply, reason: attempting to change immutable fields:
+			expectedMessage: `attempting to change immutable fields:
    - selector:
       from: map[matchLabels:map[app:old-app]]
       to:   map[matchLabels:map[app:new-app]]
@@ -2143,7 +2143,7 @@ Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordina
 					},
 				},
 			},
-			expectedMessage: `one or more objects failed to apply, reason: attempting to change immutable fields:
+			expectedMessage: `attempting to change immutable fields:
    - volumeClaimTemplates:
       from: <nil>
       to:   [data]
@@ -2175,7 +2175,7 @@ Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordina
 					},
 				},
 			},
-			expectedMessage: `one or more objects failed to apply, reason: attempting to change immutable fields:
+			expectedMessage: `attempting to change immutable fields:
    - volumeClaimTemplates:
       from: [data1]
       to:   [data1, data2]
@@ -2192,7 +2192,7 @@ Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordina
 				"serviceName":         "new-svc",
 				"podManagementPolicy": "Parallel",
 			},
-			expectedMessage: `one or more objects failed to apply, reason: attempting to change immutable fields:
+			expectedMessage: `attempting to change immutable fields:
    - podManagementPolicy:
       from: "OrderedReady"
       to:   "Parallel"