chore: enable thelper linter (#675)

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

.golangci.yaml

@@ -24,7 +24,7 @@ linters:
     - revive
     - staticcheck
     - testifylint
-#    - thelper
+    - thelper
 #    - unparam
     - unused
     - usestdlibvars

pkg/cache/cluster_test.go

@@ -74,10 +74,11 @@ var (
       - hostname: localhost`, testCreationTime.UTC().Format(time.RFC3339)))
 )
 
-func newCluster(t testing.TB, objs ...runtime.Object) *clusterCache {
-	cache := newClusterWithOptions(t, []UpdateSettingsFunc{}, objs...)
+func newCluster(tb testing.TB, objs ...runtime.Object) *clusterCache {
+	tb.Helper()
+	cache := newClusterWithOptions(tb, []UpdateSettingsFunc{}, objs...)
 
-	t.Cleanup(func() {
+	tb.Cleanup(func() {
 		cache.Invalidate()
 	})
 
@@ -860,6 +861,7 @@ func ExampleNewClusterCache_resourceUpdatedEvents() {
 }
 
 func getResourceKey(t *testing.T, obj runtime.Object) kube.ResourceKey {
+	t.Helper()
 	gvk := obj.GetObjectKind().GroupVersionKind()
 	m, err := meta.Accessor(obj)
 	require.NoError(t, err)

pkg/diff/diff_test.go

@@ -151,6 +151,7 @@ func newDeployment() *appsv1.Deployment {
 }
 
 func diff(t *testing.T, config, live *unstructured.Unstructured, options ...Option) *DiffResult {
+	t.Helper()
 	res, err := Diff(config, live, options...)
 	assert.NoError(t, err)
 	return res
@@ -754,6 +755,7 @@ func TestUnsortedEndpoints(t *testing.T) {
 }
 
 func buildGVKParser(t *testing.T) *managedfields.GvkParser {
+	t.Helper()
 	document := &openapi_v2.Document{}
 	err := proto.Unmarshal(testdata.OpenAPIV2Doc, document)
 	if err != nil {

pkg/health/health_test.go

@@ -15,12 +15,14 @@ import (
 )
 
 func assertAppHealth(t *testing.T, yamlPath string, expectedStatus HealthStatusCode) {
-	health := getHealthStatus(yamlPath, t)
+	t.Helper()
+	health := getHealthStatus(t, yamlPath)
 	assert.NotNil(t, health)
 	assert.Equal(t, expectedStatus, health.Status)
 }
 
-func getHealthStatus(yamlPath string, t *testing.T) *HealthStatus {
+func getHealthStatus(t *testing.T, yamlPath string) *HealthStatus {
+	t.Helper()
 	yamlBytes, err := os.ReadFile(yamlPath)
 	require.NoError(t, err)
 	var obj unstructured.Unstructured
@@ -69,7 +71,7 @@ func TestIngressHealth(t *testing.T) {
 }
 
 func TestCRD(t *testing.T) {
-	assert.Nil(t, getHealthStatus("./testdata/knative-service.yaml", t))
+	assert.Nil(t, getHealthStatus(t, "./testdata/knative-service.yaml"))
 }
 
 func TestJob(t *testing.T) {
@@ -108,8 +110,8 @@ func TestPod(t *testing.T) {
 }
 
 func TestApplication(t *testing.T) {
-	assert.Nil(t, getHealthStatus("./testdata/application-healthy.yaml", t))
-	assert.Nil(t, getHealthStatus("./testdata/application-degraded.yaml", t))
+	assert.Nil(t, getHealthStatus(t, "./testdata/application-healthy.yaml"))
+	assert.Nil(t, getHealthStatus(t, "./testdata/application-degraded.yaml"))
 }
 
 func TestAPIService(t *testing.T) {