fix: add suspended condition (#484)

Signed-off-by: ashutosh16 <[email protected]>

fix: add suspended condition

Signed-off-by: ashutosh16 <[email protected]>

Signed-off-by: ashutosh16 <[email protected]>

Author: ashutosh16

pkg/health/health_job.go

@@ -2,6 +2,7 @@ package health
 
 import (
 	"fmt"
+	corev1 "k8s.io/api/core/v1"
 
 	"github.com/argoproj/gitops-engine/pkg/utils/kube"
 	batchv1 "k8s.io/api/batch/v1"
@@ -29,6 +30,7 @@ func getBatchv1JobHealth(job *batchv1.Job) (*HealthStatus, error) {
 	var failMsg string
 	complete := false
 	var message string
+	isSuspended := false
 	for _, condition := range job.Status.Conditions {
 		switch condition.Type {
 		case batchv1.JobFailed:
@@ -38,6 +40,12 @@ func getBatchv1JobHealth(job *batchv1.Job) (*HealthStatus, error) {
 		case batchv1.JobComplete:
 			complete = true
 			message = condition.Message
+		case batchv1.JobSuspended:
+			complete = true
+			message = condition.Message
+			if condition.Status == corev1.ConditionTrue {
+				isSuspended = true
+			}
 		}
 	}
 	if !complete {
@@ -50,6 +58,11 @@ func getBatchv1JobHealth(job *batchv1.Job) (*HealthStatus, error) {
 			Status:  HealthStatusDegraded,
 			Message: failMsg,
 		}, nil
+	} else if isSuspended {
+		return &HealthStatus{
+			Status:  HealthStatusSuspended,
+			Message: failMsg,
+		}, nil
 	} else {
 		return &HealthStatus{
 			Status:  HealthStatusHealthy,

pkg/health/health_test.go

@@ -75,6 +75,7 @@ func TestJob(t *testing.T) {
 	assertAppHealth(t, "./testdata/job-running.yaml", HealthStatusProgressing)
 	assertAppHealth(t, "./testdata/job-failed.yaml", HealthStatusDegraded)
 	assertAppHealth(t, "./testdata/job-succeeded.yaml", HealthStatusHealthy)
+	assertAppHealth(t, "./testdata/job-suspended.yaml", HealthStatusSuspended)
 }
 
 func TestHPA(t *testing.T) {

pkg/health/testdata/job-suspended.yaml

@@ -0,0 +1,51 @@
+apiVersion: batch/v1
+kind: Job
+metadata:
+  creationTimestamp: 2018-12-02T08:19:13Z
+  labels:
+    controller-uid: f3fe3a46-f60a-11e8-aa53-42010a80021b
+    job-name: succeed
+  name: succeed
+  namespace: argoci-workflows
+  resourceVersion: "46535949"
+  selfLink: /apis/batch/v1/namespaces/argoci-workflows/jobs/succeed
+  uid: f3fe3a46-f60a-11e8-aa53-42010a80021b
+spec:
+  backoffLimit: 0
+  completions: 1
+  parallelism: 1
+  selector:
+    matchLabels:
+      controller-uid: f3fe3a46-f60a-11e8-aa53-42010a80021b
+  suspend: true
+  template:
+    metadata:
+      creationTimestamp: null
+      labels:
+        controller-uid: f3fe3a46-f60a-11e8-aa53-42010a80021b
+        job-name: succeed
+    spec:
+      containers:
+      - command:
+        - sh
+        - -c
+        - sleep 10
+        image: alpine:latest
+        imagePullPolicy: Always
+        name: succeed
+        resources: {}
+        terminationMessagePath: /dev/termination-log
+        terminationMessagePolicy: File
+      dnsPolicy: ClusterFirst
+      restartPolicy: Never
+      schedulerName: default-scheduler
+      securityContext: {}
+      terminationGracePeriodSeconds: 30
+status:
+  conditions:
+  - lastProbeTime: "2022-12-08T22:27:20Z"
+    lastTransitionTime: "2022-12-08T22:27:20Z"
+    message: Job suspended
+    reason: JobSuspended
+    status: "True"
+    type: Suspended