chore: avoid unnecessary json unmarshal (#627)

crenshaw-dev · web-flow · commit df9b446fd7d2 · 2024-09-16T16:42:18.000-04:00
Signed-off-by: Michael Crenshaw &lt;350466+crenshaw-dev@users.noreply.github.com&gt;
diff --git a/pkg/diff/diff.go b/pkg/diff/diff.go
@@ -664,12 +664,6 @@ func ThreeWayDiff(orig, config, live *unstructured.Unstructured) (*DiffResult, e
 		}
 	}
 
-	predictedLive := &unstructured.Unstructured{}
-	err = json.Unmarshal(predictedLiveBytes, predictedLive)
-	if err != nil {
-		return nil, err
-	}
-
 	return buildDiffResult(predictedLiveBytes, liveBytes), nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -664,12 +664,6 @@ func ThreeWayDiff(orig, config, live unstructured.Unstructured) (DiffResult, e`
`664`	`664`	`}`
`665`	`665`	`}`
`666`	`666`
`667`		`- predictedLive := &unstructured.Unstructured{}`
`668`		`- err = json.Unmarshal(predictedLiveBytes, predictedLive)`
`669`		`- if err != nil {`
`670`		`- return nil, err`
`671`		`- }`
`672`		`-`
`673`	`667`	`return buildDiffResult(predictedLiveBytes, liveBytes), nil`
`674`	`668`	`}`
`675`	`669`