added Discovery Group and EndpointSlice as Constants #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankur Manna <[email protected]>
AnkurManna
force-pushed
the
enhancement/skip-reconciliation-endpointslice
branch
from
c7d8ef1 to
f80a723
Compare
|
Please review this pr, as only after merging this i will be able to use these changes in argo-cd repo like https://argo-cd.readthedocs.io/en/stable/developer-guide/dependencies/ for the final pr. |
| const ( | ||
| ServiceDiscoveryGroup = "discovery.k8s.io" | ||
| ServiceDiscoveryEndpointSliceKind = "EndpointSlice" | ||
| ) |
There was a problem hiding this comment.
I think this is not necessary, as this is too specific, i.e. we don't want to potentially add any possible group to this library. My opinion is to just hard-code group and kind in the ArgoCD repo.
There was a problem hiding this comment.
@andrii-korotkov-verkada Got it. Please check argoproj/argo-cd#18876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argo-cd issue argoproj/argo-cd#18857