fix(newrelic): golangci-lint

- error wrapping %w
- http.NoBody over nil
- unused parameter 'r'
- assert errors with require

Author: 3bbbeau

pkg/services/newrelic.go

@@ -137,9 +137,9 @@ func (s newrelicService) getApplicationId(client *http.Client, appName string) (
 	q.Set("filter[name]", appName)
 	u.RawQuery = q.Encode()
 
-	req, err := http.NewRequest(http.MethodGet, u.String(), nil)
+	req, err := http.NewRequest(http.MethodGet, u.String(), http.NoBody)
 	if err != nil {
-		return "", fmt.Errorf("Failed to create filtered application request: %s", err)
+		return "", fmt.Errorf("failed to create filtered application request: %w", err)
 	}
 
 	req.Header.Set("Content-Type", "application/json")
@@ -153,7 +153,7 @@ func (s newrelicService) getApplicationId(client *http.Client, appName string) (
 
 	var data newrelicApplicationsResponse
 	if err := json.NewDecoder(resp.Body).Decode(&data); err != nil {
-		return "", fmt.Errorf("Failed to decode applications response: %s", err)
+		return "", fmt.Errorf("failed to decode applications response: %w", err)
 	}
 
 	if len(data.Applications) == 0 {
@@ -199,7 +199,7 @@ func (s newrelicService) Send(notification Notification, dest Destination) (err
 		return err
 	}
 
-	var appId = dest.Recipient
+	appId := dest.Recipient
 	if dest.Recipient != "" {
 		_, err := strconv.Atoi(dest.Recipient)
 		if err != nil {

pkg/services/newrelic_test.go

@@ -220,9 +220,7 @@ func TestSend_Newrelic(t *testing.T) {
 			Recipient: "myapp",
 		})
 
-		if !assert.NoError(t, err) {
-			t.FailNow()
-		}
+		require.NoError(t, err)
 	})
 
 	t.Run("missing config", func(t *testing.T) {
@@ -280,12 +278,12 @@ func TestGetApplicationId(t *testing.T) {
 			ApiURL: ts.URL,
 		}).(*newrelicService)
 		appId, err := service.getApplicationId(http.DefaultClient, "myapp")
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, "123456789", appId)
 	})
 
 	t.Run("application not found", func(t *testing.T) {
-		ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 			_, err := w.Write([]byte(`{"applications": []}`))
 			if !assert.NoError(t, err) {
 				t.FailNow()
@@ -301,7 +299,7 @@ func TestGetApplicationId(t *testing.T) {
 	})
 
 	t.Run("multiple matches for application name", func(t *testing.T) {
-		ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
 			_, err := w.Write([]byte(`{
 				"applications": [
 					{"id": "123456789"},