Skip to content

Commit 3f4d9cb

Browse files
committed
Disable more external tests failing due to Hardhat heuristics
1 parent 54c5b3d commit 3f4d9cb

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

test/externalTests/euler.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,11 @@ function euler_test
6161
setup_solc "$DIR" "$BINARY_TYPE" "$BINARY_PATH"
6262
download_project "$repo" "$ref_type" "$ref" "$DIR"
6363

64+
# Disable tests that won't pass on the ir presets due to Hardhat heuristics. Note that this also disables
65+
# them for other presets but that's fine - we want same code run for benchmarks to be comparable.
66+
# TODO: Remove this when https://github.com/NomicFoundation/hardhat/issues/2453 gets fixed.
67+
sed -i "/expectError: 'JUNK_UPGRADE_TEST_FAILURE'/d" test/moduleUpgrade.js
68+
6469
neutralize_package_lock
6570
neutralize_package_json_hooks
6671
force_hardhat_compiler_binary "$config_file" "$BINARY_TYPE" "$BINARY_PATH"

test/externalTests/perpetual-pools.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,12 @@ function perpetual_pools_test
5959
setup_solc "$DIR" "$BINARY_TYPE" "$BINARY_PATH"
6060
download_project "$repo" "$ref_type" "$ref" "$DIR"
6161

62+
# Disable tests that won't pass on the ir presets due to Hardhat heuristics. Note that this also disables
63+
# them for other presets but that's fine - we want same code run for benchmarks to be comparable.
64+
# TODO: Remove this when Hardhat adjusts heuristics for IR (https://github.com/nomiclabs/hardhat/issues/2115).
65+
sed -i 's|\(it\)\(("Should not allow commits that are too large"\)|\1.skip\2|g' test/PoolCommitter/commit.spec.ts
66+
sed -i 's|\(it\)\(("Should not allow for too many commitments (that bring amount over a user'\''s balance)"\)|\1.skip\2|g' test/PoolCommitter/commit.spec.ts
67+
6268
neutralize_package_lock
6369
neutralize_package_json_hooks
6470
force_hardhat_compiler_binary "$config_file" "$BINARY_TYPE" "$BINARY_PATH"

0 commit comments

Comments
 (0)