Merge pull request #12446 from ethereum/fix-eslint-warnings-in-external-test-js

Fix ESLint warnings/errors in external test JS

Author: chriseth

test/externalTests/solc-js/determinism.js

@@ -4,25 +4,25 @@ const solc = require('../index.js');
 
 tape('Deterministic Compilation', function (t) {
   t.test('DAO', function (st) {
-    var input = {};
-    var prevBytecode = null;
-    var testdir = 'test/DAO/';
-    var files = ['DAO.sol', 'Token.sol', 'TokenCreation.sol', 'ManagedAccount.sol'];
-    var i;
+    const input = {};
+    let prevBytecode = null;
+    const testdir = 'test/DAO/';
+    const files = ['DAO.sol', 'Token.sol', 'TokenCreation.sol', 'ManagedAccount.sol'];
+    let i;
     for (i in files) {
-      var file = files[i];
+      const file = files[i];
       input[file] = { content: fs.readFileSync(testdir + file, 'utf8') };
     }
     for (i = 0; i < 10; i++) {
-      var output = JSON.parse(solc.compile(JSON.stringify({
+      const output = JSON.parse(solc.compile(JSON.stringify({
         language: 'Solidity',
         settings: {
           optimizer: {
             enabled: true
           },
           outputSelection: {
             '*': {
-              '*': [ 'evm.bytecode' ]
+              '*': ['evm.bytecode']
             }
           }
         },
@@ -31,9 +31,9 @@ tape('Deterministic Compilation', function (t) {
       st.ok(output);
       st.ok(output.contracts);
       st.ok(output.contracts['DAO.sol']);
-      st.ok(output.contracts['DAO.sol']['DAO']);
-      st.ok(output.contracts['DAO.sol']['DAO'].evm.bytecode.object);
-      var bytecode = output.contracts['DAO.sol']['DAO'].evm.bytecode.object;
+      st.ok(output.contracts['DAO.sol'].DAO);
+      st.ok(output.contracts['DAO.sol'].DAO.evm.bytecode.object);
+      const bytecode = output.contracts['DAO.sol'].DAO.evm.bytecode.object;
       st.ok(bytecode.length > 0);
       if (prevBytecode !== null) {
         st.equal(prevBytecode, bytecode);